[Pharo-project] SmallLint broken -- no literalsDo: in CompiledMethod ?
Hi, I was trying out the refactoring engine, and tried to run the code critic. I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod. This appears to be the only method in the Pharo-dev image that sends this msg. Any ida what the fix should be? - on
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.) Adrian On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Right, thanks. In an older Squeak image I find: CompiledMethod>>literalsDo: aOneArgumentBlock ^self literals do:aOneArgumentBlock. - on On Oct 25, 2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
BTW, it would be cool to check this in the Pharo image. What would be the Smalltalk expression to pop open a browser on all methods that send messages that are not implemented? (Or simply to return a list of those messages?) - on On Oct 25, 2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
yes I will add a deprecated method. I do not know which changes did that. stef On Oct 25, 2008, at 12:35 PM, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
unsentMessages or something like that is available. Stef On Oct 25, 2008, at 12:49 PM, Oscar Nierstrasz wrote:
BTW, it would be cool to check this in the Pharo image.
What would be the Smalltalk expression to pop open a browser on all methods that send messages that are not implemented? (Or simply to return a list of those messages?)
- on
On Oct 25, 2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 25.10.2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Sorry, yes, I forgot to put in the deprecation... I will do that in the future. Marcus
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
On 25.10.2008, at 12:49, Oscar Nierstrasz wrote:
BTW, it would be cool to check this in the Pharo image.
What would be the Smalltalk expression to pop open a browser on all methods that send messages that are not implemented? (Or simply to return a list of those messages?)
Yes, there is SystemNavigation>>#browseAllUnimplementedCalls The only problem is that it does not highlight the message that is detected. That can be a problem in large methods to find the problematic one. Marcus
- on
On Oct 25, 2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
I fixed that problem last week. Make sure you have the latest version of Refactoring-Core loaded. Cheers, Lukas On Sat, Oct 25, 2008 at 3:51 PM, Marcus Denker <denker@iam.unibe.ch> wrote:
On 25.10.2008, at 12:35, Adrian Lienhard wrote:
Probably, "literals do:" instead of "literalsDo:" will work. (Normally, methods to be removed should first be deprecated, which apparently was not done in this case.)
Sorry, yes, I forgot to put in the deprecation... I will do that in the future.
Marcus
Adrian
On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote:
Hi,
I was trying out the refactoring engine, and tried to run the code critic.
I got a message not understood in SmalllintContext>>addLiteralsFor: which sends literalsDo: to its argument aCompiledMethod.
This appears to be the only method in the Pharo-dev image that sends this msg.
Any ida what the fix should be?
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
Code Critics from the Refactoring browser finds that kind of problems. It also highlights its findings. Lukas -- Lukas Renggli http://www.lukas-renggli.ch
Yes, I just saw that. I ran the code critics on the Regex package and immediately found 4 methods that send unimplemented messages. RxParser class>>#rareMatchProfile RxParser class>>#singleCharPrefixMatchProfile RxParser class>>#frequentMatchProfile send valueNowOrOnUnwindDo: RxParser class>>#bigHonkingStream sends asFilename I am using the latest pharo-dev with the latest updates. - on On Oct 25, 2008, at 16:44, Lukas Renggli wrote:
Code Critics from the Refactoring browser finds that kind of problems. It also highlights its findings.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
SystemNavigation default browseAllUnimplementedCalls shows 272 messages sent but unimplemented in the pharo-dev image :-( At least we know where to continue cleaning! ;-) - on On Oct 25, 2008, at 15:55, Marcus Denker wrote:
Yes, there is
SystemNavigation>>#browseAllUnimplementedCalls
The only problem is that it does not highlight the message that is detected. That can be a problem in large methods to find the problematic one.
Marcus
excellent! On Oct 25, 2008, at 5:16 PM, Oscar Nierstrasz wrote:
Yes, I just saw that.
I ran the code critics on the Regex package and immediately found 4 methods that send unimplemented messages.
RxParser class>>#rareMatchProfile RxParser class>>#singleCharPrefixMatchProfile RxParser class>>#frequentMatchProfile send valueNowOrOnUnwindDo:
RxParser class>>#bigHonkingStream sends asFilename
I am using the latest pharo-dev with the latest updates.
- on
On Oct 25, 2008, at 16:44, Lukas Renggli wrote:
Code Critics from the Refactoring browser finds that kind of problems. It also highlights its findings.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
pay attention that I'm removing etoy aggressively so I'm introducing unimplemented calls. Stef On Oct 25, 2008, at 5:18 PM, Oscar Nierstrasz wrote:
SystemNavigation default browseAllUnimplementedCalls
shows 272 messages sent but unimplemented in the pharo-dev image
:-(
At least we know where to continue cleaning! ;-)
- on
On Oct 25, 2008, at 15:55, Marcus Denker wrote:
Yes, there is
SystemNavigation>>#browseAllUnimplementedCalls
The only problem is that it does not highlight the message that is detected. That can be a problem in large methods to find the problematic one.
Marcus
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (5)
-
Adrian Lienhard -
Lukas Renggli -
Marcus Denker -
Oscar Nierstrasz -
Stéphane Ducasse