It just appear the Theme hierarchy is mess again, with what look like basic functionality methods appearing down in the hierarchy! Result: switching between theme makes text color unreadable. https://pharo.fogbugz.com/f/cases/14524/WateryTheme-broken-again -- Dr. Geo - http://drgeo.eu iStoa - http://istoa.drgeo.eu
On 24 Nov 2014, at 21:50, Hilaire <hilaire@drgeo.eu> wrote:
It just appear the Theme hierarchy is mess again, with what look like basic functionality methods appearing down in the hierarchy! Result: switching between theme makes text color unreadable.
https://pharo.fogbugz.com/f/cases/14524/WateryTheme-broken-again
Nobody did anything (the only thing I did is to remove *a lot* of duplicated methods im the hierarchy). I guess the fix you did was not actually ever integrated. (I asked, you said âsure, itâs inâ, and closed the report). Remember: everything, even the most tinty, dumb, trivial thing only is done when it is done. *Nothing* (and please stop here and thing about it: Absolutely nothing) happens by itself. Sometimes I have the feeling that people think that simple things (especially related to cleaning up things) somehow magically are happing all by itself. For sure itâs not my wonderful brain that ever needs to be concerned with it? for sure! I only do the âThe importantâ stuff! Just joking... Marcus
Marcus, I am ever amazed on your delivery abilities. That's just awesome. Phil Le 25 nov. 2014 08:16, "Marcus Denker" <marcus.denker@inria.fr> a écrit :
On 24 Nov 2014, at 21:50, Hilaire <hilaire@drgeo.eu> wrote:
It just appear the Theme hierarchy is mess again, with what look like basic functionality methods appearing down in the hierarchy! Result: switching between theme makes text color unreadable.
https://pharo.fogbugz.com/f/cases/14524/WateryTheme-broken-again
Nobody did anything (the only thing I did is to remove *a lot* of duplicated methods im the hierarchy).
I guess the fix you did was not actually ever integrated. (I asked, you said âsure, itâs inâ, and closed the report).
Remember: everything, even the most tinty, dumb, trivial thing only is done when it is done. *Nothing* (and please stop here and thing about it: Absolutely nothing) happens by itself.
Sometimes I have the feeling that people think that simple things (especially related to cleaning up things) somehow magically are happing all by itself. For sure itâs not my wonderful brain that ever needs to be concerned with it? for sure! I only do the âThe importantâ stuff! Just joking...
Marcus
Le 25/11/2014 08:16, Marcus Denker a écrit :
I guess the fix you did was not actually ever integrated. (I asked, you said âsure, itâs inâ, and closed the report).
Indeed, as I replied to you, it was integrated because that part is not broken any more, in Pharo3 (I reported for it) and in Pharo4. Hilaire -- Dr. Geo - http://drgeo.eu iStoa - http://istoa.drgeo.eu
Le 25/11/2014 08:16, Marcus Denker a écrit :
Nobody did anything (the only thing I did is to remove *a lot* of duplicated methods im the hierarchy).
Ok Switch to DarkTheme, then to WaterTheme. Text color scheme get wrong. Hilaire -- Dr. Geo - http://drgeo.eu iStoa - http://istoa.drgeo.eu
On 25 Nov 2014, at 15:24, Hilaire <hilaire@drgeo.eu> wrote:
Le 25/11/2014 08:16, Marcus Denker a écrit :
Nobody did anything (the only thing I did is to remove *a lot* of duplicated methods im the hierarchy).
Ok Switch to DarkTheme, then to WaterTheme. Text color scheme get wrong.
I think this is because of #installFullTheme if you add this to UITheme (the superclass of all) it should work: installFullTheme "Installs full theme: this theme default forts desktop background completion list colors" self beCurrent. SHPreferences setStyleTable: SHTextStylerST80 blueStyleTable. PolymorphSystemSettings desktopColor: Color lightGray lighter lighter. NECPreferences backgroundColor: UITheme current windowColor. Paragraph insertionPointColor: UITheme current caretColor.
Thanks Le 25/11/2014 15:30, Marcus Denker a écrit :
On 25 Nov 2014, at 15:24, Hilaire <hilaire@drgeo.eu> wrote:
Le 25/11/2014 08:16, Marcus Denker a écrit :
Nobody did anything (the only thing I did is to remove *a lot* of duplicated methods im the hierarchy).
Ok Switch to DarkTheme, then to WaterTheme. Text color scheme get wrong.
I think this is because of #installFullTheme
if you add this to UITheme (the superclass of all) it should work:
installFullTheme "Installs full theme: this theme default forts desktop background completion list colors"
self beCurrent. SHPreferences setStyleTable: SHTextStylerST80 blueStyleTable. PolymorphSystemSettings desktopColor: Color lightGray lighter lighter. NECPreferences backgroundColor: UITheme current windowColor. Paragraph insertionPointColor: UITheme current caretColor.
-- Dr. Geo - http://drgeo.eu iStoa - http://istoa.drgeo.eu
participants (3)
-
Hilaire -
Marcus Denker -
phil＠highoctane.be