Re: [Pharo-dev] Why was #asLegalSelector removed?
The way this was handled can be improved. It is sometimes difficult for us not in Lille to find out what is going on. - a specific issue name helps us notice what changes - check where code is used. DeprecationFinder works for that (and should add more repos and team projects). And a specific one: the rename from #asSmalltalkComment to #asComment is problematic. There are 2 kinds of thing casually known as comments: the comment text in a method, and the class comment. The method name should reflect that. Stephan
I'm usually extremely apprehensive of changing code I don't own, to the point I â sadly â contribute nearly nothing to Pharo. Now, cleaning the platform â and in this case, by cleaning, I really mean hazmat suits, industrial grade acid, and flame throwers â is going to break things. I'm all for a process to help others follow such changes, but if we want a process to work, it has to be even simpler than not having a process. In any case I don't want to have to stress over touching platform code. I think it would make sense to publish a configuration for DeprecationFinder in the configuration browser. Does it work on any Pharo image, or is it written on top of Moose ? About #asComment : since class comments are free text, any string will do and there is no escapement sequences to enforce. Maybe ideally we would have string un/escaper objects responsible for translating between free text and and specific encodings (comments, strings, regexes, URLsâ¦) On 19 February 2015 at 15:05, stephan <stephan@stack.nl> wrote:
The way this was handled can be improved. It is sometimes difficult for us not in Lille to find out what is going on.
- a specific issue name helps us notice what changes - check where code is used. DeprecationFinder works for that (and should add more repos and team projects).
And a specific one: the rename from #asSmalltalkComment to #asComment is problematic. There are 2 kinds of thing casually known as comments: the comment text in a method, and the class comment. The method name should reflect that.
Stephan
-- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
On 19/02/15 18:43, Damien Pollet wrote:
I think it would make sense to publish a configuration for DeprecationFinder in the configuration browser. Does it work on any Pharo image, or is it written on top of Moose ?
I'm trying to see if it still runs atm. Looking good in a Moose 5.1. 50 MB of package cache, 1250 monticello packages and counting. Hmm, found a bug in MooseMonticelloHTTPImporter. VHDL-cipt.24.mcz has a method name ending in _class and that confuse resolveInstanceSide: aNamedEntity I deliberately didn't put this in the configuration browser as running this code without the delay in getAllFrom:thenDo: performs a DOS attack. It also takes a lot of time to run, getting all packages and just creates a data structure that is easy to inspect. DeprecationFinder default findAllUsers just starts downloading and parsing everything. I never bothered creating a UI, as the GTInspector is good enough. Stephan
Damien I decided that living is about mistakes so I will not stress and continue to improve the platform. And from time to time I will do a mistake and we will fix it. I prefer to die because I have moved than because I feared to move because at the end I will die. Stef Le 19/2/15 18:43, Damien Pollet a écrit :
I'm usually extremely apprehensive of changing code I don't own, to the point I â sadly â contribute nearly nothing to Pharo. Now, cleaning the platform â and in this case, by cleaning, I really mean hazmat suits, industrial grade acid, and flame throwers â is going to break things. I'm all for a process to help others follow such changes, but if we want a process to work, it has to be even simpler than not having a process. In any case I don't want to have to stress over touching platform code.
I think it would make sense to publish a configuration for DeprecationFinder in the configuration browser. Does it work on any Pharo image, or is it written on top of Moose ?
About #asComment : since class comments are free text, any string will do and there is no escapement sequences to enforce. Maybe ideally we would have string un/escaper objects responsible for translating between free text and and specific encodings (comments, strings, regexes, URLsâ¦)
On 19 February 2015 at 15:05, stephan <stephan@stack.nl <mailto:stephan@stack.nl>> wrote:
The way this was handled can be improved. It is sometimes difficult for us not in Lille to find out what is going on.
- a specific issue name helps us notice what changes - check where code is used. DeprecationFinder works for that (and should add more repos and team projects).
And a specific one: the rename from #asSmalltalkComment to #asComment is problematic. There are 2 kinds of thing casually known as comments: the comment text in a method, and the class comment. The method name should reflect that.
Stephan
-- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
stepharo wrote
I prefer to die because I have moved than because I feared to move because at the end I will die.
Perfectly said :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Why-was-asLegalSelector-removed-tp4806427p4806745.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (5)
-
Damien Pollet -
Sean P. DeNigris -
stephan -
Stephan Eggermont
-
stepharo