IMPORTANT: new preLoad and postLoad process when making a fix
Hi, This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automated⦠so I added two new fields to the issue tracker: - preload - postload So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore. thanks, Esteban
Esteban Lorenzano wrote:
Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automated⦠so I added two new fields to the issue tracker:
- preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore.
thanks, Esteban
I've never used a preload or postload before in any way. Can you give an example? cheers -ben
On 23 Sep 2014, at 13:37, Ben Coman <btc@openInWorld.com> wrote:
Esteban Lorenzano wrote:
Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automated⦠so I added two new fields to the issue tracker: - preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore. thanks, Esteban
I've never used a preload or postload before in any way. Can you give an example?
then you will not have a problem :) Some times you need to prepare something or clean up things (for example, is common when working with RPackage, that you need to re-scan the system).
cheers -ben
2014-09-23 13:29 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automated⦠so I added two new fields to the issue tracker:
- preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore.
thanks, Esteban
Great! What if I want to do a "postload" only, for example if we have an issue "need to reinitialize Class Xxx"?
On 23 Sep 2014, at 13:50, Nicolai Hess <nicolaihess@web.de> wrote:
2014-09-23 13:29 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>: Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automated⦠so I added two new fields to the issue tracker:
- preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore.
thanks, Esteban
Great!
What if I want to do a "postload" only, for example if we have an issue "need to reinitialize Class Xxxâ?
the mail I sent says AND/OR⦠so that means you can express just one. Now⦠If you put something like your example, instead putting Xxx initialize. then script will fail, because is a script, not a semantic analyser :) Esteban
Esteban Lorenzano wrote:
Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automatedâ¦
I guess the observable result is this comment on Issue 14049... "Resolved (Fix Integrated) and assigned to Ben Coman by Ulysse The Galactic Monkey From Outer Space In 40240" Very cool. What is the trigger? Does it just pick up those issues with status "Resolved (Fix Reviewed by the Monkey)" or is there some interface that a group of integrators use to queue issues for integration? cheers, Ben
so I added two new fields to the issue tracker:
- preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore.
thanks, Esteban
On 23 Sep 2014, at 17:14, Ben Coman <btc@openInWorld.com> wrote:
Esteban Lorenzano wrote:
Hi,
This is a message for people doing fixes in Pharo core, and because of that doing SLICEs. Since last week Iâm changing the integration process (something transparent for most of you), to make it more automatedâ¦
I guess the observable result is this comment on Issue 14049... "Resolved (Fix Integrated) and assigned to Ben Coman by Ulysse The Galactic Monkey From Outer Space In 40240"
Very cool. What is the trigger? Does it just pick up those issues with status "Resolved (Fix Reviewed by the Monkey)" or is there some interface that a group of integrators use to queue issues for integration?
well⦠we could automate from âfix to includeâ to trigger an integration. But we still want a last level of control (to human verify the change)⦠so for now that last step (the âacceptâ trigger) is made by a small app I just finished. Not that this cannot change in the future, of course⦠but I would like a voting system, to complete automate the integration, not just because an issue is validated that the monkey, it has to be in the image. Of course Iâm talking about additions, not just bugfixes⦠anyway right now is almost there⦠:) Esteban
cheers, Ben
so I added two new fields to the issue tracker: - preload - postload
So⦠from now, if your SLICE requires one or/and the other, you need to fill those fields⦠it will not be part of the comment fields anymore. thanks, Esteban
participants (3)
-
Ben Coman -
Esteban Lorenzano -
Nicolai Hess