[Pharo-project] Weird behavior in Nautilus when doing a method rename
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF? Phil
there is 1 certain bug, that is that you cannot see the changes of the refactoring: https://code.google.com/p/pharo/issues/detail?id=7547 the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors. How about this reasoning: Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU I think I just convinced myself :D On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
Well, look at the screenshot then tell me that this is what I want. It is definitively *not* what I want. Especially unchecking that endless list of methods. Adding a "Uncheck all" "Check all" button to the Changes Browser list would help... Regards Phil 2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
hi, yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image. cheers, Esteban On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
Yes, thanks, I figured that out. A newcomer wouldn't... and renaming is pretty common. What will happen is that people will remove the method and recreate a new one. Version history will then go away. Or is the system smart enough to find out about these things? Phil 2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
hi,
yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image.
cheers, Esteban
On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
On Feb 20, 2013, at 10:53 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Yes, thanks, I figured that out. A newcomer wouldn't... and renaming is pretty common.
Yes, and a release is only once a year.. If we want to fix everything on that level, we will *never* release anything. The release is defined as something not completely unusable of the stuff we *did do*. It is not defined as "that what I would like to have".
What will happen is that people will remove the method and recreate a new one. Version history will then go away.
Are you sure the version history is kept when you do a refactoring?
Or is the system smart enough to find out about these things?
No. But that is *not* a show stopper for 2.0 If you want to improve the system in these directions, you should join 3.0 development early.
Phil
2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
hi,
yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image.
cheers, Esteban
On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
Relax. Onboarding 3.0. 2013/2/20 Marcus Denker <marcus.denker@inria.fr>:
On Feb 20, 2013, at 10:53 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Yes, thanks, I figured that out. A newcomer wouldn't... and renaming is pretty common.
Yes, and a release is only once a year..
If we want to fix everything on that level, we will *never* release anything. The release is defined as something not completely unusable of the stuff we *did do*. It is not defined as "that what I would like to have".
What will happen is that people will remove the method and recreate a new one. Version history will then go away.
Are you sure the version history is kept when you do a refactoring?
Or is the system smart enough to find out about these things?
No. But that is *not* a show stopper for 2.0
If you want to improve the system in these directions, you should join 3.0 development early.
Phil
2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
hi,
yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image.
cheers, Esteban
On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
and you are right, scoped browsing is a very powerful feature that can be tricky to newcomers... but at least now with nautilus it is there, as first option (in OB it was there, but more or less hidden in a submenu)... It is a small step, but is something... and well... we can improve in next releases, one step at a time :) Esteban On Feb 20, 2013, at 10:52 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Yes, thanks, I figured that out. A newcomer wouldn't... and renaming is pretty common.
What will happen is that people will remove the method and recreate a new one. Version history will then go away.
Or is the system smart enough to find out about these things?
Phil
2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
hi,
yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image.
cheers, Esteban
On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
I used it with OB and indeed, it helps a lot working in one's projet indeed. Phil 2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
and you are right, scoped browsing is a very powerful feature that can be tricky to newcomers... but at least now with nautilus it is there, as first option (in OB it was there, but more or less hidden in a submenu)... It is a small step, but is something... and well... we can improve in next releases, one step at a time :)
Esteban
On Feb 20, 2013, at 10:52 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Yes, thanks, I figured that out. A newcomer wouldn't... and renaming is pretty common.
What will happen is that people will remove the method and recreate a new one. Version history will then go away.
Or is the system smart enough to find out about these things?
Phil
2013/2/20 Esteban Lorenzano <estebanlm@gmail.com>:
hi,
yes, you are right.. but that is a "nice to have", not a bug... so it will wait to 3.0 :) In the mean time, you can do a scoped rename: you select the packages you want, then right click and "browse scoped", then you apply you rename, and it will apply the refactor in the scoped selection, not all the image.
cheers, Esteban
On Feb 20, 2013, at 10:21 AM, "phil@highoctane.be" <phil@highoctane.be> wrote:
Well, look at the screenshot then tell me that this is what I want.
It is definitively *not* what I want. Especially unchecking that endless list of methods.
Adding a "Uncheck all" "Check all" button to the Changes Browser list would help...
Regards Phil
2013/2/20 Camillo Bruni <camillobruni@gmail.com>:
there is 1 certain bug, that is that you cannot see the changes of the refactoring:
https://code.google.com/p/pharo/issues/detail?id=7547
the rest I would consider a bug as well. But in the terms of refactoring it might be "valid". It does preserve behavior by renaming also all implementors.
How about this reasoning:
Rename method => rename all senders (since you refactor) => you have to rename all implementors as well since you renamed all send sites otherwise you'll run for sure into a DNU
I think I just convinced myself :D
On 2013-02-20, at 09:26, "phil@highoctane.be" <phil@highoctane.be> wrote:
I was doing a Refactoring>rename of the initialize method in Nautilus for the ClassMethodBrowser and then the changes browser proposed me to change all classes with initialize. WTF?
Phil
<PharoScreenshot.3.png>
participants (4)
-
Camillo Bruni -
Esteban Lorenzano -
Marcus Denker -
phil＠highoctane.be