[Pharo-project] about nextPut: returned argument
hi guys I saw that nicolas fixed all the add: ... in squeak to return the argument and I like the idea I created an issue. Now I saw that nicolas fixed also nextPut: Item was changed: ----- Method: DummyStream>>nextPut: (in category 'accessing') ----- nextPut: aByte + "do nothing" + ^aByte! - "do nothing"! I checked the ANSI standard and this is unspecified. So I was wondering what the others dialects are doing? What do we do? Stef
This is a very minor change, but to me as important as having class comments, 'at last classified' categories etc... My rationale is : 1) #nextPut: #nextPutAll: are just like #add: #addAll: 2) that's how they historically behave 3) it's good to have homogeneity in the system Nicolas 2010/3/20 stephane ducasse <stephane.ducasse@free.fr>:
hi guys
I saw that nicolas fixed all the add: ... in squeak to return the argument and I like the idea I created an issue. Now I saw that nicolas fixed also nextPut:
Item was changed: Â ----- Method: DummyStream>>nextPut: (in category 'accessing') ----- Â nextPut: aByte + Â Â Â "do nothing" + Â Â Â ^aByte! - Â Â Â "do nothing"!
I checked the ANSI standard and this is unspecified. So I was wondering what the others dialects are doing? What do we do?
Stef _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Mar 20, 2010, at 11:00 PM, Nicolas Cellier wrote:
This is a very minor change, but to me as important as having class comments, 'at last classified' categories etc...
I imagine and for me I spent time looking at your squeak changes just for exactly the same reason.
My rationale is : 1) #nextPut: #nextPutAll: are just like #add: #addAll: 2) that's how they historically behave 3) it's good to have homogeneity in the system
yes but you did not reply to my question GS, VA, VW, GNU? Because before jumping to follow you I hold down my horses for once :) Stef
On Sat, 20 Mar 2010, Stéphane Ducasse wrote:
On Mar 20, 2010, at 11:00 PM, Nicolas Cellier wrote:
This is a very minor change, but to me as important as having class comments, 'at last classified' categories etc...
I imagine and for me I spent time looking at your squeak changes just for exactly the same reason.
My rationale is : 1) #nextPut: #nextPutAll: are just like #add: #addAll: 2) that's how they historically behave 3) it's good to have homogeneity in the system
yes but you did not reply to my question GS, VA, VW, GNU? Because before jumping to follow you I hold down my horses for once :)
Even WriteStream >> #nextPut: returns the argument (both primitive and non primitive version), so these changes give image-wide consistency. Levente
Stef _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Excellent! I like consistency Stef
This is a very minor change, but to me as important as having class comments, 'at last classified' categories etc...
I imagine and for me I spent time looking at your squeak changes just for exactly the same reason.
My rationale is : 1) #nextPut: #nextPutAll: are just like #add: #addAll: 2) that's how they historically behave 3) it's good to have homogeneity in the system
yes but you did not reply to my question GS, VA, VW, GNU? Because before jumping to follow you I hold down my horses for once :)
Even WriteStream >> #nextPut: returns the argument (both primitive and non primitive version), so these changes give image-wide consistency.
Levente
FWIW, Gemstone returns the arg.. Dale ----- "stephane ducasse" <stephane.ducasse@free.fr> wrote: | hi guys | | I saw that nicolas fixed all the add: ... in squeak to return the | argument and I like the idea I created an issue. | Now I saw that nicolas fixed also nextPut: | | Item was changed: | ----- Method: DummyStream>>nextPut: (in category 'accessing') ----- | nextPut: aByte | + "do nothing" | + ^aByte! | - "do nothing"! | | I checked the ANSI standard and this is unspecified. So I was | wondering what the others dialects are doing? | What do we do? | | Stef | _______________________________________________ | Pharo-project mailing list | Pharo-project@lists.gforge.inria.fr | http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Cool since I like the idea. This is really where the ANSI standard shows that there were probably conflict of interest.
FWIW, Gemstone returns the arg..
Dale ----- "stephane ducasse" <stephane.ducasse@free.fr> wrote:
| hi guys | | I saw that nicolas fixed all the add: ... in squeak to return the | argument and I like the idea I created an issue. | Now I saw that nicolas fixed also nextPut: | | Item was changed: | ----- Method: DummyStream>>nextPut: (in category 'accessing') ----- | nextPut: aByte | + "do nothing" | + ^aByte! | - "do nothing"! | | I checked the ANSI standard and this is unspecified. So I was | wondering what the others dialects are doing? | What do we do? | | Stef | _______________________________________________ | Pharo-project mailing list | Pharo-project@lists.gforge.inria.fr | http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (5)
-
Dale Henrichs -
Levente Uzonyi -
Nicolas Cellier -
stephane ducasse -
Stéphane Ducasse