PharoLauncher create image / default image name
I started to use a more recent version of pharo launcher, and somehow it changed how it creates the default image name when creating a new image. For example, select an entry from "Pharo 6.0 (beta)" template, the old behavior sets the default name to Pharo 6.0 (beta) - 60353 but now, the template name is omitted, it only sets 60535 was this change on purpose ? I can not find an issue about this on https://github.com/pharo-project/pharo-launcher/issues (I actually don't care much about which format to use, it is just that all my images I used from the prior version, and the new one now appear on different positions in the images list) nicolai
Le 01/02/2017 à 20:18, Nicolai Hess a écrit :
I started to use a more recent version of pharo launcher, and somehow it changed how it creates the default image name when creating a new image. For example, select an entry from "Pharo 6.0 (beta)" template, the old behavior sets the default name to Pharo 6.0 (beta) - 60353 but now, the template name is omitted, it only sets 60535
was this change on purpose ? I can not find an issue about this on https://github.com/pharo-project/pharo-launcher/issues
(I actually don't care much about which format to use, it is just that all my images I used from the prior version, and the new one now appear on different positions in the images list)
nicolai
Hi, This change was made by Christophe I think and was in purpose. Template name before: Name of the "location" (ex: Common Tools, Pharo Contribution Jenkins, Pharo 6.0â¦) - Name of the build Now: Name of the build -- Cyril Ferlicot http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
I was also looking at this, but couldn't figure out how to change it back, Do you know in what specific commit this happened? (I prefer the old naming, since it included context and I knew whether the image was Pharo or Moose). Thanks, Peter On Wed, Feb 01, 2017 at 08:23:33PM +0100, Cyril Ferlicot D. wrote:
Le 01/02/2017 à 20:18, Nicolai Hess a écrit :
I started to use a more recent version of pharo launcher, and somehow it changed how it creates the default image name when creating a new image. For example, select an entry from "Pharo 6.0 (beta)" template, the old behavior sets the default name to Pharo 6.0 (beta) - 60353 but now, the template name is omitted, it only sets 60535
was this change on purpose ? I can not find an issue about this on https://github.com/pharo-project/pharo-launcher/issues
(I actually don't care much about which format to use, it is just that all my images I used from the prior version, and the new one now appear on different positions in the images list)
nicolai
Hi,
This change was made by Christophe I think and was in purpose.
Template name before: Name of the "location" (ex: Common Tools, Pharo Contribution Jenkins, Pharo 6.0â¦) - Name of the build
Now: Name of the build
-- Cyril Ferlicot
2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
Am 03.02.2017 12:35 nachm. schrieb "Peter Uhnak" <i.uhnak@gmail.com>: I was also looking at this, but couldn't figure out how to change it back, Do you know in what specific commit this happened? PharoLauncher-Core-ChristopheDemarey.100 (I prefer the old naming, since it included context and I knew whether the image was Pharo or Moose). Thanks, Peter On Wed, Feb 01, 2017 at 08:23:33PM +0100, Cyril Ferlicot D. wrote:
Le 01/02/2017 à 20:18, Nicolai Hess a écrit :
I started to use a more recent version of pharo launcher, and somehow it changed how it creates the default image name when creating a new image. For example, select an entry from "Pharo 6.0 (beta)" template, the old behavior sets the default name to Pharo 6.0 (beta) - 60353 but now, the template name is omitted, it only sets 60535
was this change on purpose ? I can not find an issue about this on https://github.com/pharo-project/pharo-launcher/issues
(I actually don't care much about which format to use, it is just that all my images I used from the prior version, and the new one now appear on different positions in the images list)
nicolai
Hi,
This change was made by Christophe I think and was in purpose.
Template name before: Name of the "location" (ex: Common Tools, Pharo Contribution Jenkins, Pharo 6.0â¦) - Name of the build
Now: Name of the build
-- Cyril Ferlicot
2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
PharoLauncher-Core-ChristopheDemarey.100
Thanks!
If some still prefer the old naming, maybe the best way would be to have an option to choose the naming strategy.
Unless there is a critical mass of people it's imho needless clutter in the codebase; I can patch it myself locally. For me Pharo code = configuration. :) Peter
Hi, Yes, I changed it on purpose after a small survey of people in the mod group. The old naming was very annoying, especially with some templates coming from Jenkins. If some still prefer the old naming, maybe the best way would be to have an option to choose the naming strategy. Christophe
Le 3 févr. 2017 à 12:34, Peter Uhnak <i.uhnak@gmail.com> a écrit :
I was also looking at this, but couldn't figure out how to change it back,
Do you know in what specific commit this happened?
(I prefer the old naming, since it included context and I knew whether the image was Pharo or Moose).
Thanks, Peter
On Wed, Feb 01, 2017 at 08:23:33PM +0100, Cyril Ferlicot D. wrote:
Le 01/02/2017 à 20:18, Nicolai Hess a écrit :
I started to use a more recent version of pharo launcher, and somehow it changed how it creates the default image name when creating a new image. For example, select an entry from "Pharo 6.0 (beta)" template, the old behavior sets the default name to Pharo 6.0 (beta) - 60353 but now, the template name is omitted, it only sets 60535
was this change on purpose ? I can not find an issue about this on https://github.com/pharo-project/pharo-launcher/issues
(I actually don't care much about which format to use, it is just that all my images I used from the prior version, and the new one now appear on different positions in the images list)
nicolai
Hi,
This change was made by Christophe I think and was in purpose.
Template name before: Name of the "location" (ex: Common Tools, Pharo Contribution Jenkins, Pharo 6.0â¦) - Name of the build
Now: Name of the build
-- Cyril Ferlicot
2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
participants (4)
-
Christophe Demarey -
Cyril Ferlicot D. -
Nicolai Hess -
Peter Uhnak