TClassDescription: Why #comment:?
There is already #comment:stamp:. #comment: makes the stamp <historical>. When would we want that? Or if it's a convenience method, maybe it should pass `... stamp: Author changeStamp`? Also, it seems that the result of neither of these messages shows up in MC changes browser, even though they do go into the changes file and are committed by MC... ----- Cheers, Sean -- View this message in context: http://forum.world.st/TClassDescription-Why-comment-tp4821441.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Sean P. DeNigris wrote
When would we want that?
And, AFAICT there are senders (out of the 24 total) who should be using the stamp version - FileContentsBrowser>>#contents:notifying:, AbstractNautilusUI>>#openCommentEditor:... ----- Cheers, Sean -- View this message in context: http://forum.world.st/TClassDescription-Why-comment-tp4821441p4821442.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 23 Apr 2015, at 16:45, Sean P. DeNigris <sean@clipperadams.com> wrote:
Sean P. DeNigris wrote
When would we want that?
And, AFAICT there are senders (out of the 24 total) who should be using the stamp version - FileContentsBrowser>>#contents:notifying:,
this will soon go away thankfullyâ¦
AbstractNautilusUI>>#openCommentEditor:...
a comment: that sets a good default stamp should be good here, too, or not? Marcus
On 23 Apr 2015, at 16:30, Sean P. DeNigris <sean@clipperadams.com> wrote:
There is already #comment:stamp:. #comment: makes the stamp <historical>. When would we want that? Or if it's a convenience method, maybe it should pass `... stamp: Author changeStamp`?
Yes, we had in the past the problem that comments lost the stamps often⦠I wanted to remove all cases where it puts <historical>
Also, it seems that the result of neither of these messages shows up in MC changes browser, even though they do go into the changes file and are committed by MC...
Hmm.. strange. Maybe the notification is not done correctly? Marcus
Marcus Denker-4 wrote
Yes, we had in the past the problem that comments lost the stamps often⦠I wanted to remove all cases where it puts <historical>
Okay, I created Issue 15389 "Class Comments: Never Create <historical> Stamps" Marcus Denker-4 wrote
Hmm.. strange. Maybe the notification is not done correctly?
I'm having trouble reproducing it. Let's assume it was a fluke for now... ----- Cheers, Sean -- View this message in context: http://forum.world.st/TClassDescription-Why-comment-tp4821441p4821461.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (2)
-
Marcus Denker -
Sean P. DeNigris