[Pharo-project] is the monkey working on a clean image?
Because this error is strange in that case... If you continue, you will lose these changes: 1: MCVersionLoader>>warnAboutLosi ngChangesTo:ifCancel:ifMerge: 2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge: 3: MCVersionLoader>>loadWithNameLike: 4: MCVersionLoader>>load 5: GoferLoad>>execute 6: Gofer>>execute:do: 7: Gofer>>execute: 8: Gofer>>load 9: GoferResolvedReference>>load 10: [self slice load] in UlysseTheMonkey>>loadSlice ...
BTW, what do we do with false positives? I have two cases for example: - the one in the mail above. I can load the slice in a clean image, but the monkey is not doing that. - I have fixed 10 tests but as there remains 2, it rejects my fix. because If I put them as FixReviewNeeded, they will be rejected by the monkey again... and nobody will have a look at them. Maybe we can use a different status like FixReviewNeededButIHaveNoBananas ? :) On Tue, Jul 3, 2012 at 12:13 AM, Guillermo Polito <guillermopolito@gmail.com
wrote:
Because this error is strange in that case...
If you continue, you will lose these changes: 1: MCVersionLoader>>warnAboutLosi ngChangesTo:ifCancel:ifMerge: 2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge: 3: MCVersionLoader>>loadWithNameLike: 4: MCVersionLoader>>load 5: GoferLoad>>execute 6: Gofer>>execute:do: 7: Gofer>>execute: 8: Gofer>>load 9: GoferResolvedReference>>load 10: [self slice load] in UlysseTheMonkey>>loadSlice ...
We are thinking about that :) Also, if you introduce a new failing test for pointing a bug, it will be rejected, and this is wrong. The idea is to be more tolerant about the package you are modifying Ben On Jul 3, 2012, at 10:07 AM, Guillermo Polito wrote:
On Tue, Jul 3, 2012 at 10:07 AM, Guillermo Polito <guillermopolito@gmail.com> wrote: - I have fixed 10 tests but as there remains 2, it rejects my fix.
I meant "as there remains 2 other broken tests"
participants (2)
-
Benjamin -
Guillermo Polito