[Pharo4] RBEnvironment-based search is broken
in short, implementorsOf:/referencesTo:/ is broken (does not search over the class side of things). Moreover, depending on the kind of RBEnvironment one is looking at: allClasses returns only the classes or returns classes and metaclasses Of course, implementorsOf: is broken because allClasses does not returns the metaclasses. I like it when people "normalize" things :( Thierry
2015-03-09 14:18 GMT+01:00 Thierry Goubier <thierry.goubier@gmail.com>:
in short, implementorsOf:/referencesTo:/ is broken (does not search over the class side of things).
Moreover, depending on the kind of RBEnvironment one is looking at:
allClasses returns only the classes or returns classes and metaclasses
I reported a couple of issues at fogbugz related to this (actually about smalllint validations rules, but they depend on this change on RBEnvironments) And I raised some topics about this on the mailing list. I was not involved in the latest changes on RBEnvironment and don't have any project that depends on RBEnvironment. So I can *do* the fixes I proposed, but I will not make the decisions. Just waiting for feedback.
Of course, implementorsOf: is broken because allClasses does not returns the metaclasses.
I like it when people "normalize" things :(
He asked for feedback on this. And as far as I know no one complained. nicolai
Thierry
2015-03-09 14:39 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2015-03-09 14:18 GMT+01:00 Thierry Goubier <thierry.goubier@gmail.com>:
in short, implementorsOf:/referencesTo:/ is broken (does not search over the class side of things).
Moreover, depending on the kind of RBEnvironment one is looking at:
allClasses returns only the classes or returns classes and metaclasses
I reported a couple of issues at fogbugz related to this (actually about smalllint validations rules, but they depend on this change on RBEnvironments) And I raised some topics about this on the mailing list.
Ok, then we know what was the reason.
I was not involved in the latest changes on RBEnvironment and don't have any project that depends on RBEnvironment.
So I can *do* the fixes I proposed, but I will not make the decisions. Just waiting for feedback.
Which issues are we talking about? I can have a look.
Of course, implementorsOf: is broken because allClasses does not returns the metaclasses.
I like it when people "normalize" things :(
He asked for feedback on this. And as far as I know no one complained.
Fair enough. Really need to have more test cases to cover things like that :) Thierry
2015-03-09 14:43 GMT+01:00 Thierry Goubier <thierry.goubier@gmail.com>:
2015-03-09 14:39 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2015-03-09 14:18 GMT+01:00 Thierry Goubier <thierry.goubier@gmail.com>:
in short, implementorsOf:/referencesTo:/ is broken (does not search over the class side of things).
Moreover, depending on the kind of RBEnvironment one is looking at:
allClasses returns only the classes or returns classes and metaclasses
I reported a couple of issues at fogbugz related to this (actually about smalllint validations rules, but they depend on this change on RBEnvironments) And I raised some topics about this on the mailing list.
Ok, then we know what was the reason.
I was not involved in the latest changes on RBEnvironment and don't have any project that depends on RBEnvironment.
So I can *do* the fixes I proposed, but I will not make the decisions. Just waiting for feedback.
Which issues are we talking about? I can have a look.
14230 <https://pharo.fogbugz.com/default.asp?14230> Some rules aren't applied on the classside anymore 14621 <https://pharo.fogbugz.com/default.asp?14621> Some RBBrowserEnvironments don't work well with Metaclasses closed but related: 14228 <https://pharo.fogbugz.com/default.asp?14228> critic rules running on all methods of a class extended by a package (closed) 15077 <https://pharo.fogbugz.com/default.asp?15077> CriticBrowser MNU Trait>>methodClass (closed) closed, related and part of the problem: 14096 <https://pharo.fogbugz.com/default.asp?14096> Rewrite lint rules to check classes and methods 14098 <https://pharo.fogbugz.com/default.asp?14098> allClassesAndTraits significantly different from allClassesAndTraitsDo: And mailing list "discussions" http://forum.world.st/RBEnvironments-allClasses-Traits-Meta-tp4796370.html http://forum.world.st/What-is-a-Behavior-are-Traits-behavior-too-tp4804691.h...
Of course, implementorsOf: is broken because allClasses does not returns the metaclasses.
I like it when people "normalize" things :(
He asked for feedback on this. And as far as I know no one complained.
Fair enough.
Really need to have more test cases to cover things like that :)
RBEnvironments are so nice, small but really powerfull (refactoring/searching/validation). I would like to get this right.
Thierry
Thanks for the list. Stef PS: may be I'm doing too many things :) Which issues are we talking about? I can have a look.
14230 <https://pharo.fogbugz.com/default.asp?14230> Some rules aren't applied on the classside anymore 14621 <https://pharo.fogbugz.com/default.asp?14621> Some RBBrowserEnvironments don't work well with Metaclasses
closed but related: 14228 <https://pharo.fogbugz.com/default.asp?14228> critic rules running on all methods of a class extended by a package (closed) 15077 <https://pharo.fogbugz.com/default.asp?15077> CriticBrowser MNU Trait>>methodClass (closed)
closed, related and part of the problem: 14096 <https://pharo.fogbugz.com/default.asp?14096> Rewrite lint rules to check classes and methods 14098 <https://pharo.fogbugz.com/default.asp?14098> allClassesAndTraits significantly different from allClassesAndTraitsDo:
And mailing list "discussions" http://forum.world.st/RBEnvironments-allClasses-Traits-Meta-tp4796370.html http://forum.world.st/What-is-a-Behavior-are-Traits-behavior-too-tp4804691.h...
Of course, implementorsOf: is broken because allClasses does not returns the metaclasses.
I like it when people "normalize" things :(
He asked for feedback on this. And as far as I know no one complained.
Fair enough.
Really need to have more test cases to cover things like that :)
RBEnvironments are so nice, small but really powerfull (refactoring/searching/validation). I would like to get this right.
Thierry
Hi what were the changes in RBEnvironment?
in short, implementorsOf:/referencesTo:/ is broken (does not search over the class side of things).
Moreover, depending on the kind of RBEnvironment one is looking at:
allClasses returns only the classes or returns classes and metaclasses
I reported a couple of issues at fogbugz related to this (actually about smalllint validations rules, but they depend on this change on RBEnvironments)
Do you have the issue number?
And I raised some topics about this on the mailing list.
I was not involved in the latest changes on RBEnvironment and don't have any project that depends on RBEnvironment.
So I can *do* the fixes I proposed, but I will not make the decisions. Just waiting for feedback.
Of course, implementorsOf: is broken because allClasses does not returns the metaclasses.
I like it when people "normalize" things :(
He asked for feedback on this. And as far as I know no one complained.
Not enough users of RB environment. I really think that we should write more tests because this is part that can be tested and we can spot regression. Ideally I would like to get - unification between SystemDictionary as a leave in a hierarchy whose root would be RBEnviroment - get systemNavigation unified with RBEnviroment Now what I would like the most is time :) Stef
nicolai
Thierry
participants (3)
-
Nicolai Hess -
stepharo -
Thierry Goubier