[Pharo-project] FileStream speed up
Hi levente can you have a look at the attached cs? I integrated up (ul47 -> ul.58) to the change of david because I would prefer that marcus has a look at them Thanks stef
On Wed, 20 Jan 2010, Stéphane Ducasse wrote:
Hi levente
can you have a look at the attached cs?
I had a quick look and found that the changes for MultiByteFileStream are still missing. Those are the first that you should apply. Why? Because some methods (#upToEnd IIRC) use the collection instance variable for no reason. If you keep that method and apply the changes to StandardFileStream, (as I pointed out earlier) the system may break. Also the fix from Files-ul.67 is missing (StandardFileStream >> #upTo:). I suggest you to make 3 steps to integrate the changes: 1. Integrate the changes to MultiByteFileStream 2. Integrate the changes to StandardFileStream 3. Evaluate: StandardFileStream allSubInstancesDo: [ :each | each closed ifFalse: [ each enableReadBuffering ] ] Then save the image, run tests, reopen the image, run tests. Every test should pass which passed before. Levente
thanks I will have a look and follow your advice.
Hi levente
can you have a look at the attached cs?
I had a quick look and found that the changes for MultiByteFileStream are still missing. Those are the first that you should apply. Why? Because some methods (#upToEnd IIRC) use the collection instance variable for no reason. If you keep that method and apply the changes to StandardFileStream, (as I pointed out earlier) the system may break. Also the fix from Files-ul.67 is missing (StandardFileStream >> #upTo:).
I suggest you to make 3 steps to integrate the changes: 1. Integrate the changes to MultiByteFileStream 2. Integrate the changes to StandardFileStream 3. Evaluate: StandardFileStream allSubInstancesDo: [ :each | each closed ifFalse: [ each enableReadBuffering ] ] Then save the image, run tests, reopen the image, run tests. Every test should pass which passed before.
Levente_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Levente Uzonyi -
Stéphane Ducasse