[Pharo-project] Issue 3980 in pharo: TestResource fails to makeAvailable an never recovers
Status: Accepted Owner: guillerm...@gmail.com New issue 3980 by guillerm...@gmail.com: TestResource fails to makeAvailable an never recovers http://code.google.com/p/pharo/issues/detail?id=3980 Using Pharo 1.2 TestResource>>makeAvailable "This method must be the _only_ way to set a notNil value for the unique instance (current). First, obtain a candidate instance and set current to a notNil placeholder (any notNil object not an instance of me would do; this version uses false). Next, check any subordinate resources needed by this resource. Lastly, setUp the candidate and put it in current if it is available, ensuring that it is torn down otherwise." | candidate | current := false. candidate := self new. .... And everywhere in the class, the check over the current var is done like current isNil ifTrue: .... So once that var is initialized, but the makeAvailable fails, it always fails...
Updates: Status: FixProposed Comment #1 on issue 3980 by guillerm...@gmail.com: TestResource fails to makeAvailable an never recovers http://code.google.com/p/pharo/issues/detail?id=3980 current should be assigned to nil, not to false. fix proposed in the inbox Name: SLICE-Issue-3980-TestResource-fails-to-makeAvailable-an-never-recovers-GuillermoPolito.1 Author: GuillermoPolito Time: 10 April 2011, 9:31:08 pm UUID: 8959ec71-7ade-47e0-bc26-d0d32d4075c7 Ancestors: Dependencies: SUnit-GuillermoPolito.40123 current initialized to nil in makeAvailable
Updates: Labels: Milestone-1.2.2 Milestone-1.3 Comment #2 on issue 3980 by marcus.d...@gmail.com: TestResource fails to makeAvailable an never recovers http://code.google.com/p/pharo/issues/detail?id=3980 (No comment was entered for this change.)
Comment #3 on issue 3980 by marcus.d...@gmail.com: TestResource fails to makeAvailable an never recovers http://code.google.com/p/pharo/issues/detail?id=3980 in 13141 TODO: 1.2
Updates: Status: Closed Comment #4 on issue 3980 by marcus.d...@gmail.com: TestResource fails to makeAvailable an never recovers http://code.google.com/p/pharo/issues/detail?id=3980 in 12347
participants (1)
-
pharo@googlecode.com