[Pharo-project] StringTest>>testUnescapePercentsWithTextEncoding is broken
While checking if tests for the Squeak by Example book still work under Pharo, I discovered that StringTest>>testUnescapePercentsWithTextEncoding is broken. Trying to track this down, I saw that Michael Rueger changed the last line of ShiftJISTextConverter>>nextFromStream: from ^ self toUnicode: result to: ^ self byteToUnicode: result which seems to break the test. I can't say that I understand what is going on here, but shouldn't we roll back this change? Else rewrite the test ... - on
Already reported issue, should be fixed in latest Pharo 2009/5/13 Oscar Nierstrasz <oscar@iam.unibe.ch>:
While checking if tests for the Squeak by Example book still work under Pharo, I discovered that StringTest>>testUnescapePercentsWithTextEncoding is broken.
Trying to track this down, I saw that Michael Rueger changed the last line of ShiftJISTextConverter>>nextFromStream: from
    ^ self toUnicode: result
to:
    ^ self byteToUnicode: result
which seems to break the test.
I can't say that I understand what is going on here, but shouldn't we roll back this change? Â Else rewrite the test ...
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Ah -- looked in the wrong place. Found it now. Thanks. - on On May 13, 2009, at 15:32, Nicolas Cellier wrote:
Already reported issue, should be fixed in latest Pharo
2009/5/13 Oscar Nierstrasz <oscar@iam.unibe.ch>:
While checking if tests for the Squeak by Example book still work under Pharo, I discovered that StringTest>>testUnescapePercentsWithTextEncoding is broken.
Trying to track this down, I saw that Michael Rueger changed the last line of ShiftJISTextConverter>>nextFromStream: from
^ self toUnicode: result
to:
^ self byteToUnicode: result
which seems to break the test.
I can't say that I understand what is going on here, but shouldn't we roll back this change? Else rewrite the test ...
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Nicolas Cellier -
Oscar Nierstrasz