Re: [Pharo-project] Networking change in Pharo 1.2?
On Apr 19, 2011, at 5:16 PM, Chris Muller wrote:
Then I look at the new code called by #localHostAddress and becomes obvious why:
isConnected "Dirty, but avoids fixing the plugin bug" [NetNameResolver addressForName: 'www.esug.org'.] on: NameLookupFailure do: [:ex| ^false]. ^true
A hard-coded nslookup to 'www.esug.org' wrapped in an exception-handler? Wow!
Ups.... (shamefuly looking somewhere else, as I harvested the change...) We will fix it. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
Ups.... (shamefuly looking somewhere else, as I harvested the change...)
No problem Marcus. I think it would be difficult to do a better job than what you do. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
+1 but we should write some specific tests. On Apr 19, 2011, at 10:40 PM, Alexandre Bergel wrote:
Ups.... (shamefuly looking somewhere else, as I harvested the change...)
No problem Marcus. I think it would be difficult to do a better job than what you do.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
participants (3)
-
Alexandre Bergel -
Marcus Denker -
Stéphane Ducasse