[Pharo-project] mariano could you publish the popup fixes ;)
Here it is. Please, can someone see it? I did two things: 1) I removed the popup because I has no sense in my opinion. I just set the default font is there is no one. Is there a risk in what I did? This is the first time I play with Fonts so perhaps I am doing something wrong. 2) The test was green, even when there was the popup. It was a matter of the font size. However, I don't like my solution. I would love to know where those defaults fonts came from but I don't know. Does someone know how can I do this? see the changes to understand what I am saying ;) Finally, I will then change it again because I don't like how this test is done. I think it should implement the setUp and tearDown methods and move code there. But I will do this later on. I continue with my Seaside tutorial at ESGU ;) best Mariano 2009/9/1 Stéphane Ducasse <stephane.ducasse@inria.fr>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I created the ticket http://code.google.com/p/pharo/issues/detail?id=1140 and publish my changes on PharoInbox: Name: System-Support-MarianoMartinezPeck.77 Author: MarianoMartinezPeck Time: 1 September 2009, 12:12:27 pm UUID: cd0f579f-d2ad-47ab-a6c5-7354bdf156cb Ancestors: System-Support-StephaneDucasse.76 Name: Tests-MarianoMartinezPeck.12 Author: MarianoMartinezPeck Time: 1 September 2009, 12:14:25 pm UUID: fe61f1bb-bef8-49e8-be16-6bb9800dad9a Ancestors: Tests-AdrianLienhard.11 Fix to bug 1140 "Remove popUp and test fail" On Tue, Sep 1, 2009 at 11:37 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
Here it is. Please, can someone see it? I did two things:
1) I removed the popup because I has no sense in my opinion. I just set the default font is there is no one. Is there a risk in what I did? This is the first time I play with Fonts so perhaps I am doing something wrong.
2) The test was green, even when there was the popup. It was a matter of the font size. However, I don't like my solution. I would love to know where those defaults fonts came from but I don't know. Does someone know how can I do this? see the changes to understand what I am saying ;)
Finally, I will then change it again because I don't like how this test is done. I think it should implement the setUp and tearDown methods and move code there. But I will do this later on.
I continue with my Seaside tutorial at ESGU ;)
best
Mariano
2009/9/1 Stéphane Ducasse <stephane.ducasse@inria.fr>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Great I would love to have some times to have a look but esug is driving me crazy. Stef On Sep 1, 2009, at 5:15 PM, Mariano Martinez Peck wrote:
I created the ticket http://code.google.com/p/pharo/issues/detail?id=1140
and publish my changes on PharoInbox:
Name: System-Support-MarianoMartinezPeck.77 Author: MarianoMartinezPeck Time: 1 September 2009, 12:12:27 pm UUID: cd0f579f-d2ad-47ab-a6c5-7354bdf156cb Ancestors: System-Support-StephaneDucasse.76
Name: Tests-MarianoMartinezPeck.12 Author: MarianoMartinezPeck Time: 1 September 2009, 12:14:25 pm UUID: fe61f1bb-bef8-49e8-be16-6bb9800dad9a Ancestors: Tests-AdrianLienhard.11
Fix to bug 1140 "Remove popUp and test fail"
On Tue, Sep 1, 2009 at 11:37 AM, Mariano Martinez Peck <marianopeck@gmail.com
wrote:
Here it is. Please, can someone see it? I did two things:
1) I removed the popup because I has no sense in my opinion. I just set the default font is there is no one. Is there a risk in what I did? This is the first time I play with Fonts so perhaps I am doing something wrong.
2) The test was green, even when there was the popup. It was a matter of the font size. However, I don't like my solution. I would love to know where those defaults fonts came from but I don't know. Does someone know how can I do this? see the changes to understand what I am saying ;)
Finally, I will then change it again because I don't like how this test is done. I think it should implement the setUp and tearDown methods and move code there. But I will do this later on.
I continue with my Seaside tutorial at ESGU ;)
best
Mariano
2009/9/1 Stéphane Ducasse <stephane.ducasse@inria.fr>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Mariano Martinez Peck -
Stéphane Ducasse