[Pharo-project] SLICE-Mantis-KernelNumber-Fix-Mining-nice.1.mcz
I push here some more or less important fixes. These are limited to one or two method per fix and should not take very long to review. Cheers Nicolas This gathers several Tests and Fixes from Mantis for Kernel-Number ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6781 0.0 raisedTo: -1.0 unexpected result The patch correct Number >> #raisedTo: and uses [^self class one] so that Float >> #raisedTo; can be removed (99% identical code). ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6729 -Infinity closeTo: Infinity self deny: (Float infinity negated closeTo: Float infinity) ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6695 Float storeStringBase: does not store the radix self assert: (20.0 storeStringBase: 16) = '16r14.0' compare to this: (20 storeStringBase: 16) Note: in base 10, radix is not prepended (same as Integer). ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6697 Number>>storeOn:base: default implementation is wrong Default implementation does omit the radix prefix when it should not! Change it to subclassResponsibility, since every subclass will have a different one... ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=6990 0.0 significandAsInteger is too big ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=7114 SmallInteger minVal highBitOfMagnitude Try it, it should not raise an Error... ------------------------------------------------------------ http://bugs.squeak.org/view.php?id=5640 additional tests and fixes for Number>>printShowingDecimalPlaces: http://bugs.squeak.org/view.php?id=7028 printShowingDecimalPlaces: is broken in 3.10 Try (-0.9 printShowingDecimalPlaces: 1) for example... Where is the minus sign? Fix included in 3.10 is incorrect and not complete ------------------------------------------------------------
participants (1)
-
nicolas cellier