Re: [Pharo-dev] [regression reporter]regression occurred
On 25 Jun 2014, at 10:06, no-reply@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
5 regressions found. Tests.System.Hashing.SHA256Tests.testClassComment Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses Tests.System.Hashing.SHA256Tests.testNew Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods
I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, instance side: classToBeTested ^ SHA256 Sorry about that. Sven
no problem open a bug entry. Stef On 25/6/14 10:37, Sven Van Caekenberghe wrote:
On 25 Jun 2014, at 10:06, no-reply@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
5 regressions found. Tests.System.Hashing.SHA256Tests.testClassComment Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses Tests.System.Hashing.SHA256Tests.testNew Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, instance side:
classToBeTested ^ SHA256
Sorry about that.
Sven
I reopened https://pharo.fogbugz.com/f/cases/13395/Add-SHA256-HashFunction On 26 Jun 2014, at 07:45, stepharo <stepharo@free.fr> wrote:
no problem open a bug entry.
Stef
On 25/6/14 10:37, Sven Van Caekenberghe wrote:
On 25 Jun 2014, at 10:06, no-reply@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
5 regressions found. Tests.System.Hashing.SHA256Tests.testClassComment Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses Tests.System.Hashing.SHA256Tests.testNew Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, instance side:
classToBeTested ^ SHA256
Sorry about that.
Sven
On 26 Jun 2014, at 08:13, Sven Van Caekenberghe <sven@stfx.eu> wrote:
I reopened https://pharo.fogbugz.com/f/cases/13395/Add-SHA256-HashFunction
Why? i fixed that already yesterday (by renaming the class so the default worksâ¦) Is it important to re-name it again and add the #classToBeTested?
On 26 Jun 2014, at 07:45, stepharo <stepharo@free.fr> wrote:
no problem open a bug entry.
Stef
On 25/6/14 10:37, Sven Van Caekenberghe wrote:
On 25 Jun 2014, at 10:06, no-reply@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
5 regressions found. Tests.System.Hashing.SHA256Tests.testClassComment Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses Tests.System.Hashing.SHA256Tests.testNew Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, instance side:
classToBeTested ^ SHA256
Sorry about that.
Sven
I have not yet downloaded a latest image and tried it myself, but I do not understand why https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label... fails, it does not fail in my working image (see my file out). That is the only problem left, the renaming is not necessary if this problem can be fixed. On 26 Jun 2014, at 08:15, Marcus Denker <marcus.denker@inria.fr> wrote:
On 26 Jun 2014, at 08:13, Sven Van Caekenberghe <sven@stfx.eu> wrote:
I reopened https://pharo.fogbugz.com/f/cases/13395/Add-SHA256-HashFunction
Why? i fixed that already yesterday (by renaming the class so the default worksâ¦)
Is it important to re-name it again and add the #classToBeTested?
On 26 Jun 2014, at 07:45, stepharo <stepharo@free.fr> wrote:
no problem open a bug entry.
Stef
On 25/6/14 10:37, Sven Van Caekenberghe wrote:
On 25 Jun 2014, at 10:06, no-reply@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
5 regressions found. Tests.System.Hashing.SHA256Tests.testClassComment Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses Tests.System.Hashing.SHA256Tests.testNew Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, instance side:
classToBeTested ^ SHA256
Sorry about that.
Sven
On 26 Jun 2014, at 08:20, Sven Van Caekenberghe <sven@stfx.eu> wrote:
I have not yet downloaded a latest image and tried it myself, but I do not understand why
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
fails, it does not fail in my working image (see my file out).
That is the only problem left, the renaming is not necessary if this problem can be fixed.
Nautilus does not run the tests that are inherited (we should fix that). If you use the Testrunner, the test fails. It can be fixed by adding a class comment. Marcus
On 26 Jun 2014, at 08:35, Marcus Denker <marcus.denker@inria.fr> wrote:
On 26 Jun 2014, at 08:20, Sven Van Caekenberghe <sven@stfx.eu> wrote:
I have not yet downloaded a latest image and tried it myself, but I do not understand why
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
fails, it does not fail in my working image (see my file out).
That is the only problem left, the renaming is not necessary if this problem can be fixed.
Nautilus does not run the tests that are inherited (we should fix that).
If you use the Testrunner, the test fails.
I know.
It can be fixed by adding a class comment.
I never publish anything without a class comment, it was there in the file out, SHA256.st I will have a look at the 40 image myself.
I added a SLICE to https://pharo.fogbugz.com/f/cases/13395/Add-SHA256-HashFunction that adds the comment On 26 Jun 2014, at 08:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 26 Jun 2014, at 08:35, Marcus Denker <marcus.denker@inria.fr> wrote:
On 26 Jun 2014, at 08:20, Sven Van Caekenberghe <sven@stfx.eu> wrote:
I have not yet downloaded a latest image and tried it myself, but I do not understand why
https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label...
fails, it does not fail in my working image (see my file out).
That is the only problem left, the renaming is not necessary if this problem can be fixed.
Nautilus does not run the tests that are inherited (we should fix that).
If you use the Testrunner, the test fails.
I know.
It can be fixed by adding a class comment.
I never publish anything without a class comment, it was there in the file out, SHA256.st
I will have a look at the 40 image myself.
participants (3)
-
Marcus Denker -
stepharo -
Sven Van Caekenberghe