[Pharo-project] Changes aren't saved in the default (unnamed) changeset on a new image
Hi! I'm using the develop Pharo-1.1-11367-Beta on windows. When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok. Is it a bug or a 'feature'? Cheers, Guille
where is it saved? it may be a bug create a bug entry with a nice description :) Stef On Jun 4, 2010, at 5:23 PM, Guillermo Polito wrote:
Hi!
I'm using the develop Pharo-1.1-11367-Beta on windows.
When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok.
Is it a bug or a 'feature'?
Cheers, Guille _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
They are not saved :D, that's what motivated me to send this email :P. I'll open one :) On Fri, Jun 4, 2010 at 1:18 PM, Stéphane Ducasse <stephane.ducasse@inria.fr>wrote:
where is it saved? it may be a bug create a bug entry with a nice description :)
Stef On Jun 4, 2010, at 5:23 PM, Guillermo Polito wrote:
Hi!
I'm using the develop Pharo-1.1-11367-Beta on windows.
When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok.
Is it a bug or a 'feature'?
Cheers, Guille _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi Guille. I could reproduce the problem. Please create an issue and put milestone 1.1. More investigation: in PharoCore it works perfect, the problem is with PharoDev. More details: the problem is in ScriptLoader >> cleanUpForRelease This method is being call when the Dev image is created. If you take a PharoCore, the changeset are working well. Take that image, and evaluate ScriptLoader nwe cleanUpForRelease. After this, it should start the problem you mention. Can you reproduce this? Now, we need to see where the problem is in cleanUpForRelease. We need some debugging here. No time now. Maybe it is related to the lines: ChangeSet removeChangeSetsNamedSuchThat: [ :each | true ]. ChangeSet resetCurrentToNewUnnamedChangeSet. but just a guess. Cheers mariano 2010/6/4 Guillermo Polito <guillermopolito@gmail.com>
They are not saved :D, that's what motivated me to send this email :P.
I'll open one :)
On Fri, Jun 4, 2010 at 1:18 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
where is it saved? it may be a bug create a bug entry with a nice description :)
Stef On Jun 4, 2010, at 5:23 PM, Guillermo Polito wrote:
Hi!
I'm using the develop Pharo-1.1-11367-Beta on windows.
When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok.
Is it a bug or a 'feature'?
Cheers, Guille _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
http://code.google.com/p/pharo/issues/detail?id=2504&colspec=ID%20Type%20Sta... :) 2010/6/4 Mariano Martinez Peck <marianopeck@gmail.com>
Hi Guille. I could reproduce the problem. Please create an issue and put milestone 1.1.
More investigation: in PharoCore it works perfect, the problem is with PharoDev.
More details: the problem is in ScriptLoader >> cleanUpForRelease
This method is being call when the Dev image is created. If you take a PharoCore, the changeset are working well. Take that image, and evaluate ScriptLoader nwe cleanUpForRelease. After this, it should start the problem you mention. Can you reproduce this?
Now, we need to see where the problem is in cleanUpForRelease. We need some debugging here. No time now. Maybe it is related to the lines:
ChangeSet removeChangeSetsNamedSuchThat: [ :each | true ]. ChangeSet resetCurrentToNewUnnamedChangeSet.
but just a guess.
Cheers
mariano
2010/6/4 Guillermo Polito <guillermopolito@gmail.com>
They are not saved :D, that's what motivated me to send this email :P.
I'll open one :)
On Fri, Jun 4, 2010 at 1:18 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
where is it saved? it may be a bug create a bug entry with a nice description :)
Stef On Jun 4, 2010, at 5:23 PM, Guillermo Polito wrote:
Hi!
I'm using the develop Pharo-1.1-11367-Beta on windows.
When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok.
Is it a bug or a 'feature'?
Cheers, Guille _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Oook, I updated the image and realized that the issue was fixed in a cleaning of ScriptLoader>>cleanUpForRelease. The problem was that the changesets cleaning was duplicated and the second cleaning was in the wrong order. But now, playing with the cleanUpFor Release I noticed that the first time you clean the image, the default changeset keeps dirty because of the changes made in the cleanUp. I set this issue as fixed and opened this new one: http://code.google.com/p/pharo/issues/detail?id=2515&q=changeset&colspec=ID%... I found a fix, but I would like someone to reproduce it. Cheers, Guille On Fri, Jun 4, 2010 at 7:21 PM, Guillermo Polito <guillermopolito@gmail.com>wrote:
http://code.google.com/p/pharo/issues/detail?id=2504&colspec=ID%20Type%20Sta...
:)
2010/6/4 Mariano Martinez Peck <marianopeck@gmail.com>
Hi Guille. I could reproduce the problem. Please create an issue and put
milestone 1.1.
More investigation: in PharoCore it works perfect, the problem is with PharoDev.
More details: the problem is in ScriptLoader >> cleanUpForRelease
This method is being call when the Dev image is created. If you take a PharoCore, the changeset are working well. Take that image, and evaluate ScriptLoader nwe cleanUpForRelease. After this, it should start the problem you mention. Can you reproduce this?
Now, we need to see where the problem is in cleanUpForRelease. We need some debugging here. No time now. Maybe it is related to the lines:
ChangeSet removeChangeSetsNamedSuchThat: [ :each | true ]. ChangeSet resetCurrentToNewUnnamedChangeSet.
but just a guess.
Cheers
mariano
2010/6/4 Guillermo Polito <guillermopolito@gmail.com>
They are not saved :D, that's what motivated me to send this email :P.
I'll open one :)
On Fri, Jun 4, 2010 at 1:18 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
where is it saved? it may be a bug create a bug entry with a nice description :)
Stef On Jun 4, 2010, at 5:23 PM, Guillermo Polito wrote:
Hi!
I'm using the develop Pharo-1.1-11367-Beta on windows.
When I make a change with a fresh image, that change isn't saved in the default changeset :(. In the Core image it's just ok.
Is it a bug or a 'feature'?
Cheers, Guille _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (3)
-
Guillermo Polito -
Mariano Martinez Peck -
Stéphane Ducasse