[Pharo-project] Issue 3499 in pharo: FixUnderscores (package & instructions) out of date
Status: New Owner: ---- New issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 Pharo image: Core 1.2 #12270 The CollaborActive book says to mcz version 18, however 17 is already loaded as of 1.1, so I propose: * integrate 18 into trunk * update book (e.g. remove installation step from book - I will do this once the package is integrated) I much prefer using this package over RB because it does not alter the method's timestamp. p.s. this does raise the point of documentation for difference Pharo versions. If the installation step is removed from the book, it will create extra work/confusion for 1.0 users; but if it is left in, it will be a continuing distraction for current users.
Updates: Status: accepted Comment #1 on issue 3499 by stephane.ducasse: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 We should not maintain documentation for 1.0 users when we are not even able to have a decent documentation. So upgrading the documentation to the current version is the only way. Now I do not understand why you want to integrate 18 in the trunk since in 1.2 there is 20.
Comment #2 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 "I do not understand why you want to integrate 18 in the trunk since in 1.2 there is 20." Just a mistake. I meant "update to the latest version", and thought 18 was it.
Comment #3 on issue 3499 by stephane.ducasse: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 ok so we can close it for 1.2 and we just have to update the description on the webpage?
Comment #4 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 1.2 #12272 has v. 20 but there is a 22 in the Pharo repo. Will that be integrated into 1.2?
Comment #5 on issue 3499 by marianopeck: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 I would not integrate the package of FixUnderscore if it has problems with timestamps. Instead I would update the webpage with the RB code to do the same. You can get it from http://code.google.com/p/pharo/wiki/CodeSnippets (title How to fix underscore assigment with RB ?) again, I think FixUnderscore should not be part of a PharoCore image (I even remember remoiving it). I don't have an image handy now...are you sure it is present in pharo 1.2 ?
Comment #6 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 It's present in 1.2#12283 just downloaded. But what is the problem with the timestamps? I consider not changing the timestamps to be a feature because there is no semantic change in the code.
Comment #7 on issue 3499 by miguel.coba: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 I also think that the FixUnderscores are a bad solution to the problem. The point of having the source code versioned is to track *every* change to it. that includes, accents, spaces, newlines, and of course, source code. I don't know why the underscores should be treated differently. It *is* a change in the code. And it is good to have the source code management system to trackit. Even if no other change more semantic was made. So I vote also for the rules for the refactoring browser and the lint rules to search for underscores in the core image.
Comment #8 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 Okay, I'm not really attached to it, so if everyone thinks RB is the way to go, let's remove the FU package and I'll update the book.
Comment #9 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 The book has been updated, instructing to use RB only http://book.pharo-project.org/book/TipsAndTricks/FixingUnderscores
Comment #10 on issue 3499 by stephane.ducasse: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 We should not update 22 now why do you remove the description using FixUnderscore from the book. People can take their responsibility.
Updates: Status: closed Comment #11 on issue 3499 by stephane.ducasse: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 (No comment was entered for this change.)
Comment #12 on issue 3499 by sean.p.denigris: FixUnderscores (package & instructions) out of date http://code.google.com/p/pharo/issues/detail?id=3499 It seemed like the consensus is that FixUnderscores leads to code that's not properly versioned and should be removed from core. Why include instructions for something we don't want people to use?
participants (1)
-
pharo＠googlecode.com