[Pharo-project] Issue 3280 in pharo: Focus indicator for pluggable text morphs not correctly drawn
Status: New Owner: gazzaguru2 CC: marcus.denker New issue 3280 by gazzaguru2: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 Fix below... TextMorphForEditView keyboardFocusChange: aBoolean "rr 3/21/2004 22:55 : removed the #ifFalse: branch, which was responsible of the deselection of text when the paragraph lost focus. This way selection works in a more standard way, and this permits the menu keyboard control to be really effective. Changed to update focus indication." paragraph ifNotNil: [paragraph focused: aBoolean]. aBoolean ifTrue: ["A hand is wanting to send us characters..." self hasFocus ifFalse: [self editor "Forces editor install"]. self editor focused: true. self useFindReplaceSelection ifTrue: [self selectionChanged]. Editor blinkingCursor ifTrue: [self startBlinking]] ifFalse:[editor ifNotNil: [editor focused: false]. self stopBlinking]. self editView ifNil: [self focusChanged] ifNotNil: [self editView focusChanged]
Updates: Status: Fixed Comment #1 on issue 3280 by aplantec: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 Thank Gary, I've made a slice for it. SLICE-Issue-3280-FocusIndicatorForPluggableTextMorphsNotCorrectlyDrawn.
Updates: Labels: Milestone-1.2 Comment #2 on issue 3280 by aplantec: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 (No comment was entered for this change.)
Comment #3 on issue 3280 by gazzaguru2: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 Noticed that the blinking cursor sometimes hangs around now though... (since optimised to only redraw the focus indictor parts) try: keyboardFocusChange: aBoolean "rr 3/21/2004 22:55 : removed the #ifFalse: branch, which was responsible of the deselection of text when the paragraph lost focus. This way selection works in a more standard way, and this permits the menu keyboard control to be really effective. Changed to update focus indication." paragraph ifNotNil: [paragraph focused: aBoolean]. aBoolean ifTrue: ["A hand is wanting to send us characters..." self hasFocus ifFalse: [self editor "Forces editor install"]. self editor focused: true. self useFindReplaceSelection ifTrue: [self selectionChanged]. Editor blinkingCursor ifTrue: [self startBlinking]] ifFalse:[editor ifNotNil: [editor focused: false]. self resetBlinkCursor; stopBlinking]. self editView ifNil: [self focusChanged] ifNotNil: [self editView focusChanged]
Comment #4 on issue 3280 by aplantec: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 I've also noticed that the cursor is lost when you enter something in the filter field of a PopupChoiceDialogWindow. for example, the Browser>>findClass
Comment #5 on issue 3280 by gazzaguru2: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 That's deliberate (the list has the focus...)
Comment #6 on issue 3280 by aplantec: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 It seems to me that the list get the keyboard focus on a up or down arrow. But while typing in the filter field, this one has the keyboard focus so, my opinion is that the cursor should be continuously drawn in the filter field.
Comment #7 on issue 3280 by gazzaguru2: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 Though technically an unrelated issue try the following to see if you like it better ;-) PopupChoiceDialogWindow filter: aString "Set the value of filter, used to match the valid choices." filter := aString. self changed: #filter. (self choiceMenus ifNil: [^self]) do: [:embeddedMenu | embeddedMenu selectItem: nil event: nil]. "clear selection in other menus" self choiceMenus do: [:embeddedMenu | embeddedMenu selectMatch: self filter asLowercase]. self filterMorph hasKeyboardFocus ifFalse: [ self activeHand newKeyboardFocus: self filterMorph. self filterMorph selectFrom: filter size + 1 to: filter size + 1]
Comment #8 on issue 3280 by aplantec: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 yes, much better for me. thanks!
Comment #9 on issue 3280 by gazzaguru2: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 You'll need this too to allow return key when filter has focus to do the ok action... newFilterEntry "Answer a new filter entry field." |entry| entry := self newAutoAcceptTextEntryFor: self getText: #filter setText: #filter: getEnabled: nil help: 'Filters the options according to a matching substring' translated. entry acceptOnCR: false. entry textMorph crAction: (MessageSend receiver: self selector: #ok). ^entry
Updates: Status: Closed Comment #10 on issue 3280 by marcus.denker: Focus indicator for pluggable text morphs not correctly drawn http://code.google.com/p/pharo/issues/detail?id=3280 12253
participants (1)
-
pharo@googlecode.com