[Request for comment] Hermes package
... to all participating authors of the Hermes package: PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE So many uncommented classes in there today... We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough. If you have time to write code then you also have the time to write a simple class comment! So please do you homework (which is a general request to authors of other packages as well) Bye T.
Hi, Sorry I have missed the comments. I will add them as soon as possible. You are right we should improve the quality, thanks for checking it and remembering everybody. Cheers, On Wed, Feb 28, 2018 at 10:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
-- Pablo Tesone. tesonep@gmail.com
Side question: What is Hermes? Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
Hermes is a private binary format that is used to load compiled code when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages. Stef On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Side question: What is Hermes?
Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
While it is very bootstrap oriented library it would be better to rename it to BootstapCodeLoader. Or PharoBootstrap-CodeLoader because we already use this prefix 2018-03-01 13:20 GMT+01:00 Stephane Ducasse <stepharo.self@gmail.com>:
Hermes is a private binary format that is used to load compiled code when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages.
Stef
On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Side question: What is Hermes?
Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
+1 On Thu, Mar 1, 2018 at 2:42 PM, Denis Kudriashov <dionisiydk@gmail.com> wrote:
While it is very bootstrap oriented library it would be better to rename it to BootstapCodeLoader. Or PharoBootstrap-CodeLoader because we already use this prefix
2018-03-01 13:20 GMT+01:00 Stephane Ducasse <stepharo.self@gmail.com>:
Hermes is a private binary format that is used to load compiled code when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages.
Stef
On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Side question: What is Hermes?
Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
Nice Idea, I have added comments to the packages, classes and methods. This will be in the new version that will be integrated with the new Traits implementation. I am still cleaning some comments that Denis and Pavel have done and we can integrate it. Then we change the name, I liked BootstrapCodeLoader, I think I can find a non conflicting prefix. Cheers. On Thu, Mar 1, 2018 at 4:29 PM, Stephane Ducasse <stepharo.self@gmail.com> wrote:
+1
On Thu, Mar 1, 2018 at 2:42 PM, Denis Kudriashov <dionisiydk@gmail.com> wrote:
While it is very bootstrap oriented library it would be better to rename it to BootstapCodeLoader. Or PharoBootstrap-CodeLoader because we already use this prefix
2018-03-01 13:20 GMT+01:00 Stephane Ducasse <stepharo.self@gmail.com>:
Hermes is a private binary format that is used to load compiled code when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages.
Stef
On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Side question: What is Hermes?
Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de>
wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
-- Pablo Tesone. tesonep@gmail.com
Thanks Pablo this is cool! On Thu, Mar 1, 2018 at 4:42 PM, tesonep@gmail.com <tesonep@gmail.com> wrote:
Nice Idea, I have added comments to the packages, classes and methods. This will be in the new version that will be integrated with the new Traits implementation. I am still cleaning some comments that Denis and Pavel have done and we can integrate it.
Then we change the name, I liked BootstrapCodeLoader, I think I can find a non conflicting prefix.
Cheers.
On Thu, Mar 1, 2018 at 4:29 PM, Stephane Ducasse <stepharo.self@gmail.com> wrote:
+1
On Thu, Mar 1, 2018 at 2:42 PM, Denis Kudriashov <dionisiydk@gmail.com> wrote:
While it is very bootstrap oriented library it would be better to rename it to BootstapCodeLoader. Or PharoBootstrap-CodeLoader because we already use this prefix
2018-03-01 13:20 GMT+01:00 Stephane Ducasse <stepharo.self@gmail.com>:
Hermes is a private binary format that is used to load compiled code when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages.
Stef
On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Side question: What is Hermes?
Alexandre
On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <astares@gmx.de> wrote:
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE
So many uncommented classes in there today...
We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough.
If you have time to write code then you also have the time to write a simple class comment!
So please do you homework (which is a general request to authors of other packages as well)
Bye T.
-- Pablo Tesone. tesonep@gmail.com
participants (5)
-
Alexandre Bergel -
Denis Kudriashov -
Stephane Ducasse -
tesonep＠gmail.com -
Torsten Bergmann