[Pharo-project] MultiCompositionScanner depending on Morphic stuff
*- MultiCompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide: * depends on TextLine which is packaged as Morphic-Text Support - *MultiCompositionScanner>>setFont* depends on TextComposer which is packaged as Morphic-Text Support also http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=13317344... Guille
Good catch We should move them close to MultiCompositionScanner Stef On Mar 14, 2012, at 3:14 PM, Guillermo Polito wrote:
- MultiCompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:
depends on TextLine which is packaged as Morphic-Text Support
- MultiCompositionScanner>>setFont
depends on TextComposer which is packaged as Morphic-Text Support also
http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=13317344...
Guille
On Wed, Mar 14, 2012 at 11:14 AM, Guillermo Polito < guillermopolito@gmail.com> wrote:
*- MultiCompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide: *
depends on TextLine which is packaged as Morphic-Text Support
TextLine seems that can be safely moved along with MultiCompositionScanner.
- *MultiCompositionScanner>>setFont*
depends on TextComposer which is packaged as Morphic-Text Support also
This dependency is only for this method: TextComposer class>>characterForColumnBreak ^Character value: 12 But if this method is so used by the scanner, then we can move it to the scanner and revert the dependency :)
http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=13317344...
Guille
TextLine seems that can be safely moved along with MultiCompositionScanner.
good!
- MultiCompositionScanner>>setFont
depends on TextComposer which is packaged as Morphic-Text Support also
This dependency is only for this method:
TextComposer class>>characterForColumnBreak
^Character value: 12
I do not get it. because Character is not in Morphic
But if this method is so used by the scanner, then we can move it to the scanner and revert the dependency :)
http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=13317344...
Guille
MultiCompositionScanner>>setFont uses TextComposer>>characterForColumnBreak... What I do suggest is to move #characterForColumnBreak to the scanner (or make the scanner know its composer instead of hardcoding the reference). But since I don't really know these classes I'm totally blind :/ On Thu, Mar 15, 2012 at 1:04 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
TextLine seems that can be safely moved along with
MultiCompositionScanner.
good!
- MultiCompositionScanner>>setFont
depends on TextComposer which is packaged as Morphic-Text Support also
This dependency is only for this method:
TextComposer class>>characterForColumnBreak
^Character value: 12
I do not get it. because Character is not in Morphic
But if this method is so used by the scanner, then we can move it to the scanner and revert the dependency :)
http://code.google.com/p/pharo/issues/detail?id=5478&thanks=5478&ts=13317344...
Guille
Hey, composition scanners and display scanners should not belong to Kernel. they should be either in graphics package or in morphic itself. Why we moved this stuff to kernel? -- Best regards, Igor Stasenko.
Igor I would not put it in Morphic. Now it depends which kernel we are talking about. Because may be text should be a large kernel. Stef On Mar 15, 2012, at 5:32 PM, Igor Stasenko wrote:
Hey, composition scanners and display scanners should not belong to Kernel. they should be either in graphics package or in morphic itself.
Why we moved this stuff to kernel?
-- Best regards, Igor Stasenko.
participants (3)
-
Guillermo Polito -
Igor Stasenko -
Stéphane Ducasse