[Pharo-project] Issue 3870 in pharo: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew
Status: Accepted Owner: marcus.d...@gmail.com Labels: Milestone-1.3 New issue 3870 by marcus.d...@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870
KernelTests.Methods.CompiledMethodTest.testNew 0.0 1
Comment #1 on issue 3870 by nicolas....@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870 First, there is a missing subclassResponsibility in CompiledMethodTest Fixing this is not enough... The aim of the failing test is to check (CompiledMethod new) which never worked and shouldn't IMO. So #testNew should be among #selectorsToBeIgnored
Comment #2 on issue 3870 by nicolas....@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870 But that is still not enough... #selectorsToBeIgnored is itself ignored for determining the test suite... What a mess ! It seems that other subclasses do redefine #testNew...
Comment #3 on issue 3870 by marcus.d...@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870 I think we should deprecate ClassTestCase... at the time it looked like a nice idea, but in the meantime I got convinced that for tests, less magic is better and code duplication is not a problem. So all subclasses should just implement the handfull of tests that ClassTestCase provides themselves and we remove it.
Updates: Status: FixProposed Comment #4 on issue 3870 by nicolas....@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870 Name: SLICE-Issue-3870-CompiledMethodTest-testNew-nice.1 Dependencies: SUnit-nice.40123, KernelTests-nice.320 Fix #testNew and a missing subclass responsibility. Also fix a duplicated protocol 'Coverage' vs 'coverage' in super class (SUnit).
Updates: Status: Closed Comment #5 on issue 3870 by marcus.d...@gmail.com: [Failing Test] 1.3 KernelTests.Methods.CompiledMethodTest.testNew http://code.google.com/p/pharo/issues/detail?id=3870 in 13136
participants (1)
-
pharo＠googlecode.com