[Pharo-project] Refactoring-Extensions-Environment
Hi, RPackage loads the ConfigurationOfPharoRB, and this one loads Refactoring-Extensions-Environment. The problem is that in this package there is a reference to an unknown selectedEnvironment variable, and this breaks OB (browse package): BrowserEnvironmentWrapper>>selectionIntervalFor: aString | interval | interval := super selectionIntervalFor: aString. ^interval notNil ifTrue: [interval] ifFalse: [selectedEnvironment selectionIntervalFor: aString] It should probably use the environment variable. I wanted to commit, but I do not have the rights. Cheers, Doru -- www.tudorgirba.com "Not knowing how to do something is not an argument for how it cannot be done."
I should remove the dependency to PharoRB. I will do that know. Stef On Aug 21, 2011, at 9:45 PM, Tudor Girba wrote:
Hi,
RPackage loads the ConfigurationOfPharoRB, and this one loads Refactoring-Extensions-Environment. The problem is that in this package there is a reference to an unknown selectedEnvironment variable, and this breaks OB (browse package):
BrowserEnvironmentWrapper>>selectionIntervalFor: aString | interval | interval := super selectionIntervalFor: aString. ^interval notNil ifTrue: [interval] ifFalse: [selectedEnvironment selectionIntervalFor: aString]
It should probably use the environment variable. I wanted to commit, but I do not have the rights.
Cheers, Doru
-- www.tudorgirba.com
"Not knowing how to do something is not an argument for how it cannot be done."
Normal selected environment was defined in our branch or RB and I was loading our branch so this should not be the problem. but I removed the dependency to RB since RPackage does not need it in the latest config so let me know if this is ok for you. Just that I needed to start to check the users of PackageInfo. Stef On Aug 21, 2011, at 9:45 PM, Tudor Girba wrote:
Hi,
RPackage loads the ConfigurationOfPharoRB, and this one loads Refactoring-Extensions-Environment. The problem is that in this package there is a reference to an unknown selectedEnvironment variable, and this breaks OB (browse package):
BrowserEnvironmentWrapper>>selectionIntervalFor: aString | interval | interval := super selectionIntervalFor: aString. ^interval notNil ifTrue: [interval] ifFalse: [selectedEnvironment selectionIntervalFor: aString]
It should probably use the environment variable. I wanted to commit, but I do not have the rights.
Cheers, Doru
-- www.tudorgirba.com
"Not knowing how to do something is not an argument for how it cannot be done."
Thanks. It works better now. Cheers, Doru On 21 Aug 2011, at 23:40, Stéphane Ducasse wrote:
Normal selected environment was defined in our branch or RB and I was loading our branch so this should not be the problem. but I removed the dependency to RB since RPackage does not need it in the latest config so let me know if this is ok for you. Just that I needed to start to check the users of PackageInfo.
Stef
On Aug 21, 2011, at 9:45 PM, Tudor Girba wrote:
Hi,
RPackage loads the ConfigurationOfPharoRB, and this one loads Refactoring-Extensions-Environment. The problem is that in this package there is a reference to an unknown selectedEnvironment variable, and this breaks OB (browse package):
BrowserEnvironmentWrapper>>selectionIntervalFor: aString | interval | interval := super selectionIntervalFor: aString. ^interval notNil ifTrue: [interval] ifFalse: [selectedEnvironment selectionIntervalFor: aString]
It should probably use the environment variable. I wanted to commit, but I do not have the rights.
Cheers, Doru
-- www.tudorgirba.com
"Not knowing how to do something is not an argument for how it cannot be done."
-- www.tudorgirba.com "What is more important: To be happy, or to make happy?"
participants (2)
-
Stéphane Ducasse -
Tudor Girba