[Pharo-project] a.4 combox box bug
Hi guys when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it. I do not see why we get this behavior. Stef
I checked: it works in 14055 and not in 14057 - Issue 4513: ScrollBar and MorphicModel needs cleaning. Stef and Igor killing tha big monster - Part one. :) http://code.google.com/p/pharo/issues/detail?id=4513'. - Issue 4513: ScrollBar and MorphicModel needs cleaning. Stef and Igor killing tha big monster - Part two. :) http://code.google.com/p/pharo/issues/detail?id=4513 Gary it would be good that you check because we have two ways to to a perform: accessor and setValueSelector while only one would be enough. So I imagine that we broke the combox box. Now may be there is another bug because I do not understand why we do not see the messages changed. Because it worked in 14061 but now in 14063 we get an empty list and I do not understand why. Stef On Jul 28, 2011, at 10:25 PM, Stéphane Ducasse wrote:
Hi guys
when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it.
I do not see why we get this behavior.
Stef
I found the bug... Fixing it right now -> update soon. On Jul 28, 2011, at 10:25 PM, Stéphane Ducasse wrote:
Hi guys
when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it.
I do not see why we get this behavior.
Stef
just for education purpose.... yes it was like that delete model isMorphicModel ifFalse: [^ super delete]. slotName ifNotNil: [(self confirm: 'Shall I remove the slot "' translated , slotName , '"\along with all associated methods?' withCRs translated) ifTrue: [(model class selectors select: [:s | s beginsWith: slotName]) do: [:s | model class removeSelector: s]. (model class instVarNames includes: slotName) ifTrue: [model class removeInstVarNamed: slotName]] ifFalse: [(self confirm: '...but should I at least dismiss this morph?' translated , ('\' , 'Choose "No" to leave everything unchanged' translated) withCRs) ifFalse: [^ self]]]. super delete and we turn it into delete model isMorphicModel ifFalse: [^ super delete]. instead of delete model isMorphicModel ifFalse: [^ super delete]. super delete -> deleting delete
On Jul 28, 2011, at 11:04 31PM, Stéphane Ducasse wrote:
just for education purpose.... yes it was like that
delete model isMorphicModel ifFalse: [^ super delete]. slotName ifNotNil: [(self confirm: 'Shall I remove the slot "' translated , slotName , '"\along with all associated methods?' withCRs translated) ifTrue: [(model class selectors select: [:s | s beginsWith: slotName]) do: [:s | model class removeSelector: s]. (model class instVarNames includes: slotName) ifTrue: [model class removeInstVarNamed: slotName]] ifFalse: [(self confirm: '...but should I at least dismiss this morph?' translated , ('\' , 'Choose "No" to leave everything unchanged' translated) withCRs) ifFalse: [^ self]]]. super delete
and we turn it into
delete model isMorphicModel ifFalse: [^ super delete].
instead of
delete model isMorphicModel ifFalse: [^ super delete]. super delete
-> deleting delete
Really? That logic makes even less sense! "If it's not something, do supers implementation. Else, do super behaviour" Sounds like you could just delete the method instead, imho :P Or does super delete return something other than self, and senders rely on this being different if we're a model or not? Would be really, really, really weird :) Cheers, Henry
I found the bug... Fixing it right now -> update soon. On Jul 28, 2011, at 10:25 PM, Stéphane Ducasse wrote:
Hi guys
when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it.
I do not see why we get this behavior.
Stef
Yeah, i remember that when we looked at this method we both were highly confused about what it does. No surprise , we left a bug :) On 29 July 2011 00:07, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I found the bug... Fixing it right now -> update soon.
On Jul 28, 2011, at 10:25 PM, Stéphane Ducasse wrote:
Hi guys
when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it.
I do not see why we get this behavior.
Stef
-- Best regards, Igor Stasenko AKA sig.
:) delete or delete => remove delete :) On Jul 29, 2011, at 1:13 AM, Igor Stasenko wrote:
Yeah, i remember that when we looked at this method we both were highly confused about what it does. No surprise , we left a bug :)
On 29 July 2011 00:07, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I found the bug... Fixing it right now -> update soon.
On Jul 28, 2011, at 10:25 PM, Stéphane Ducasse wrote:
Hi guys
when I open the new recent message list in 14063 I do not get the list and it I click on the by... The combox box gets displayed but I cannot get rid of it.
I do not see why we get this behavior.
Stef
-- Best regards, Igor Stasenko AKA sig.
No problem :) Indeed this method was really strange and this is why we were wrong thinking that our semantics was better. Stef
:)
delete or delete => remove delete :)
Disregard my last mail. That's what I get for not read mail for couple of days, then briefly scan list for replies, and miss one :)
Cheers, Henry
participants (3)
-
Henrik Johansen -
Igor Stasenko -
Stéphane Ducasse