[Review]: Issue 13159: ListDialogWindow - Grow Width to Fit List
https://pharo.fogbugz.com/default.asp?13159 Right now, it doesn't do a very good job of sizing itself. See the screenshot below of the Metacello Configuration Browsers "Switch Repository" dialog. The width is insufficient for the tool to be resizable without first manually resizing. <http://forum.world.st/file/n4825490/Screenshot_2015-05-09_09.png> Fix in inbox, validated by monkey: SLICE-Issue-13159-ListDialogWindow---Grow-Width-to-Fit-List-SeanDeNigris.1 - Keep extent relatively consistent with the contained list morph ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-13159-ListDialogWindow-Grow-Width-to-Fit-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
2015-05-09 22:08 GMT+02:00 Sean P. DeNigris <sean@clipperadams.com>:
https://pharo.fogbugz.com/default.asp?13159
Right now, it doesn't do a very good job of sizing itself. See the screenshot below of the Metacello Configuration Browsers "Switch Repository" dialog. The width is insufficient for the tool to be resizable without first manually resizing.
<http://forum.world.st/file/n4825490/Screenshot_2015-05-09_09.png>
Fix in inbox, validated by monkey: SLICE-Issue-13159-ListDialogWindow---Grow-Width-to-Fit-List-SeanDeNigris.1 - Keep extent relatively consistent with the contained list morph
Does not work well in all situations (-> https://pharo.fogbugz.com/default.asp?13159#BugEvent.126933) Maybe optimal extent should be at least as large as the initial extent. And when the dialog opens in its inital extent it shortly afterward resizes. This short and sudden change looks strange.
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-13159-ListDialogWindow-Grow-Width-to-Fit-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Nicolai Hess wrote
Does not work well in all situations...
Thanks for the great review! Fix in inbox: SLICE-Issue-13159-ListDialogWindow---Grow-Width-to-Fit-List-SeanDeNigris.2 ### This version - Don't go smaller than the default size - Make sure fits in world, and it not occluded by docking toolbars As for the jarring resize, it is because the list is lazy and we don't have enough info during #initialExtent to properly size it. IMHO it's better to have a dialog where you can actually see the info at the cost of a UI glitch, but I'm happy if someone wants to dive into the lazy list process stuff and improve the fix :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-13159-ListDialogWindow-Grow-Width-to-Fit-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (2)
-
Nicolai Hess -
Sean P. DeNigris