In environments we have two methods: #definesClass: and #includesClass:. They make sense for package environments, as one of them may include a class as it defines extension methods for it, but itâs not defining the class itself. Now #includesClass: is redefined in all environments, but #definesClass: is not redefined anywhere except for package environment. So for example ClassEnvironment says that it defines every class that itâs asked about. Should we redefine that method in each environment? I would say yes, but Iâm not familiar with RBâ¦Stuff philosophy. What do you think? Cheers. Uko
On 03 Jul 2014, at 10:09, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
In environments we have two methods: #definesClass: and #includesClass:. They make sense for package environments, as one of them may include a class as it defines extension methods for it, but itâs not defining the class itself. Now #includesClass: is redefined in all environments, but #definesClass: is not redefined anywhere except for package environment. So for example ClassEnvironment says that it defines every class that itâs asked about. Should we redefine that method in each environment? I would say yes, but Iâm not familiar with RBâ¦Stuff philosophy. What do you think?
I think it should be redefined, e.g. a ClassEnvironment just defines the one class it stands for, I would say. Marcus
Good, I will implement this and submit a slice. Thanks. Uko On 03 Jul 2014, at 10:27, Marcus Denker <marcus.denker@inria.fr> wrote:
On 03 Jul 2014, at 10:09, Yuriy Tymchuk <yuriy.tymchuk@me.com> wrote:
In environments we have two methods: #definesClass: and #includesClass:. They make sense for package environments, as one of them may include a class as it defines extension methods for it, but itâs not defining the class itself. Now #includesClass: is redefined in all environments, but #definesClass: is not redefined anywhere except for package environment. So for example ClassEnvironment says that it defines every class that itâs asked about. Should we redefine that method in each environment? I would say yes, but Iâm not familiar with RBâ¦Stuff philosophy. What do you think?
I think it should be redefined, e.g. a ClassEnvironment just defines the one class it stands for, I would say.
Marcus
participants (2)
-
Marcus Denker -
Yuriy Tymchuk