Hi Bloc is broken because UserManager is no longer in the image. (it was removed on 14th of August) For some reason there is a check: UserManager default canDropOSFile this check is used in #dropFiles: What is alternative or does it make sense to remove the check? Cheers, Alex
On 04 Oct 2015, at 19:10, Aliaksei Syrel <alex.syrel@gmail.com> wrote:
Hi
Bloc is broken because UserManager is no longer in the image. (it was removed on 14th of August) For some reason there is a check:
UserManager default canDropOSFile
this check is used in #dropFiles:
What is alternative or does it make sense to remove the check?
remove it for now. We need to re-introduce something like user manager, but not one that is reference from everywhere but more using a scheme like the Settings⦠Marcus
Hi Aliak The design of the UserManager was ****plain**** bad. It was reintroducing this ugly facade singleton pattern (monolitic and global) like the old Preferences class that we fight a lot with alain and finally replace by setting. It was a mistake that I did not have the time to review the code. (BTW we were pushing too much code in the system without a good review). Now this period is over. The solution of the new approach should be the same than settings. - first any part that should be user managed should do it locally and introduce its own hooks to do so but be self-contained: exactly like Setting. A class uses class variables and check its class variables when doing something. - It means that as a client of the part I can change some accesses. - then we decorate such user-managed hooks and provide tools. Stef
Bloc is broken because UserManager is no longer in the image. (it was removed on 14th of August) For some reason there is a check:
UserManager default canDropOSFile
this check is used in #dropFiles:
What is alternative or does it make sense to remove the check?
Cheers, Alex
Hi Stef, Thanks for explanation! I agree and looking forward to see a new solution :) Cheers, Alex On Tue, Oct 6, 2015 at 8:26 AM, stepharo <stepharo@free.fr> wrote:
Hi Aliak
The design of the UserManager was ****plain**** bad. It was reintroducing this ugly facade singleton pattern (monolitic and global) like the old Preferences class that we fight a lot with alain and finally replace by setting. It was a mistake that I did not have the time to review the code. (BTW we were pushing too much code in the system without a good review). Now this period is over.
The solution of the new approach should be the same than settings.
- first any part that should be user managed should do it locally and introduce its own hooks to do so but be self-contained: exactly like Setting. A class uses class variables and check its class variables when doing something.
- It means that as a client of the part I can change some accesses.
- then we decorate such user-managed hooks and provide tools.
Stef
Bloc is broken because UserManager is no longer in the image. (it was removed on 14th of August) For some reason there is a check:
UserManager default canDropOSFile
this check is used in #dropFiles:
What is alternative or does it make sense to remove the check?
Cheers, Alex
Ah, but http://objology.blogspot.fr/2011/09/one-of-best-bits-of-programming-advice.h... You've got a score of two ending -er in a single class, tsss... ;) Nicolas 2015-10-06 21:53 GMT+02:00 Aliaksei Syrel <alex.syrel@gmail.com>:
Hi Stef,
Thanks for explanation! I agree and looking forward to see a new solution :)
Cheers, Alex
On Tue, Oct 6, 2015 at 8:26 AM, stepharo <stepharo@free.fr> wrote:
Hi Aliak
The design of the UserManager was ****plain**** bad. It was reintroducing this ugly facade singleton pattern (monolitic and global) like the old Preferences class that we fight a lot with alain and finally replace by setting. It was a mistake that I did not have the time to review the code. (BTW we were pushing too much code in the system without a good review). Now this period is over.
The solution of the new approach should be the same than settings.
- first any part that should be user managed should do it locally and introduce its own hooks to do so but be self-contained: exactly like Setting. A class uses class variables and check its class variables when doing something.
- It means that as a client of the part I can change some accesses.
- then we decorate such user-managed hooks and provide tools.
Stef
Bloc is broken because UserManager is no longer in the image. (it was removed on 14th of August) For some reason there is a check:
UserManager default canDropOSFile
this check is used in #dropFiles:
What is alternative or does it make sense to remove the check?
Cheers, Alex
;)
Ah, but http://objology.blogspot.fr/2011/09/one-of-best-bits-of-programming-advice.h... You've got a score of two ending -er in a single class, tsss... ;)
Nicolas
participants (4)
-
Aliaksei Syrel -
Marcus Denker -
Nicolas Cellier -
stepharo