[Pharo-project] Can we change diff-generator to ignore white-space diffs?
Because it makes things unreadable. Here, i replaced spaces with tabs.. and see what happens. -- Best regards, Igor Stasenko.
An approach that I've used in the past is to use a formatter both sides of the comparison ... Dale ----- Original Message ----- | From: "Igor Stasenko" <siguctua@gmail.com> | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | Sent: Saturday, March 10, 2012 5:21:28 PM | Subject: [Pharo-project] Can we change diff-generator to ignore white-space diffs? | | Because it makes things unreadable. | Here, i replaced spaces with tabs.. and see what happens. | | | -- | Best regards, | Igor Stasenko. |
On 11 March 2012 02:27, Dale Henrichs <dhenrich@vmware.com> wrote:
An approach that I've used in the past is to use a formatter both sides of the comparison ...
Well, the point is that formatting changes are visible without any highlighting. And if you will use formatter, then you won't see that guy actually just (re)formatted code.
Dale
----- Original Message ----- | From: "Igor Stasenko" <siguctua@gmail.com> | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | Sent: Saturday, March 10, 2012 5:21:28 PM | Subject: [Pharo-project] Can we change diff-generator to ignore white-space  diffs? | | Because it makes things unreadable. | Here, i replaced spaces with tabs.. and see what happens. | | | -- | Best regards, | Igor Stasenko. |
-- Best regards, Igor Stasenko.
"ignoring whitespace" means? ----- Original Message ----- | From: "Igor Stasenko" <siguctua@gmail.com> | To: Pharo-project@lists.gforge.inria.fr | Sent: Saturday, March 10, 2012 5:44:39 PM | Subject: Re: [Pharo-project] Can we change diff-generator to ignore white-space diffs? | | On 11 March 2012 02:27, Dale Henrichs <dhenrich@vmware.com> wrote: | > An approach that I've used in the past is to use a formatter both | > sides of the comparison ... | > | | Well, the point is that formatting changes are visible without any | highlighting. | And if you will use formatter, then you won't see that guy actually | just (re)formatted code. | | > Dale | > | > ----- Original Message ----- | > | From: "Igor Stasenko" <siguctua@gmail.com> | > | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | > | Sent: Saturday, March 10, 2012 5:21:28 PM | > | Subject: [Pharo-project] Can we change diff-generator to ignore | > | white-space  diffs? | > | | > | Because it makes things unreadable. | > | Here, i replaced spaces with tabs.. and see what happens. | > | | > | | > | -- | > | Best regards, | > | Igor Stasenko. | > | | > | | | | -- | Best regards, | Igor Stasenko. | |
formatted source code doesn't show up as different anyway? ----- Original Message ----- | From: "Dale Henrichs" <dhenrich@vmware.com> | To: Pharo-project@lists.gforge.inria.fr | Sent: Saturday, March 10, 2012 5:53:01 PM | Subject: Re: [Pharo-project] Can we change diff-generator to ignore white-space diffs? | | "ignoring whitespace" means? | | ----- Original Message ----- | | From: "Igor Stasenko" <siguctua@gmail.com> | | To: Pharo-project@lists.gforge.inria.fr | | Sent: Saturday, March 10, 2012 5:44:39 PM | | Subject: Re: [Pharo-project] Can we change diff-generator to ignore | | white-space diffs? | | | | On 11 March 2012 02:27, Dale Henrichs <dhenrich@vmware.com> wrote: | | > An approach that I've used in the past is to use a formatter both | | > sides of the comparison ... | | > | | | | Well, the point is that formatting changes are visible without any | | highlighting. | | And if you will use formatter, then you won't see that guy actually | | just (re)formatted code. | | | | > Dale | | > | | > ----- Original Message ----- | | > | From: "Igor Stasenko" <siguctua@gmail.com> | | > | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | | > | Sent: Saturday, March 10, 2012 5:21:28 PM | | > | Subject: [Pharo-project] Can we change diff-generator to ignore | | > | white-space  diffs? | | > | | | > | Because it makes things unreadable. | | > | Here, i replaced spaces with tabs.. and see what happens. | | > | | | > | | | > | -- | | > | Best regards, | | > | Igor Stasenko. | | > | | | > | | | | | | | | -- | | Best regards, | | Igor Stasenko. | | | | | |
Using the formatter means that you get to focus on only the semantic changes and all format related changes are filtered for you .... I'd rather not be bothered with diffs for methods that were merely formatted, but that's just me. Dale ----- Original Message ----- | From: "Dale Henrichs" <dhenrich@vmware.com> | To: Pharo-project@lists.gforge.inria.fr | Sent: Saturday, March 10, 2012 5:53:52 PM | Subject: Re: [Pharo-project] Can we change diff-generator to ignore white-space diffs? | | formatted source code doesn't show up as different anyway? | | ----- Original Message ----- | | From: "Dale Henrichs" <dhenrich@vmware.com> | | To: Pharo-project@lists.gforge.inria.fr | | Sent: Saturday, March 10, 2012 5:53:01 PM | | Subject: Re: [Pharo-project] Can we change diff-generator to ignore | | white-space diffs? | | | | "ignoring whitespace" means? | | | | ----- Original Message ----- | | | From: "Igor Stasenko" <siguctua@gmail.com> | | | To: Pharo-project@lists.gforge.inria.fr | | | Sent: Saturday, March 10, 2012 5:44:39 PM | | | Subject: Re: [Pharo-project] Can we change diff-generator to | | | ignore | | | white-space diffs? | | | | | | On 11 March 2012 02:27, Dale Henrichs <dhenrich@vmware.com> | | | wrote: | | | > An approach that I've used in the past is to use a formatter | | | > both | | | > sides of the comparison ... | | | > | | | | | | Well, the point is that formatting changes are visible without | | | any | | | highlighting. | | | And if you will use formatter, then you won't see that guy | | | actually | | | just (re)formatted code. | | | | | | > Dale | | | > | | | > ----- Original Message ----- | | | > | From: "Igor Stasenko" <siguctua@gmail.com> | | | > | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | | | > | Sent: Saturday, March 10, 2012 5:21:28 PM | | | > | Subject: [Pharo-project] Can we change diff-generator to | | | > | ignore | | | > | white-space  diffs? | | | > | | | | > | Because it makes things unreadable. | | | > | Here, i replaced spaces with tabs.. and see what happens. | | | > | | | | > | | | | > | -- | | | > | Best regards, | | | > | Igor Stasenko. | | | > | | | | > | | | | | | | | | | | | -- | | | Best regards, | | | Igor Stasenko. | | | | | | | | | | | |
On 11 March 2012 02:58, Dale Henrichs <dhenrich@vmware.com> wrote:
Using the formatter means that you get to focus on only the semantic changes and all format related changes are filtered for you ....
I'd rather not be bothered with diffs for methods that were merely formatted, but that's just me.
unless, you reformatted code and refactored it a bit. Now because of overlapping highlights, i cannot verify, what exactly changes i did. And the worst of all is , when i click ' pretty print' it barks with error "Undefined object are not indexable'... :) as in Pharo1.4a Latest update: #14379
Dale ----- Original Message ----- | From: "Dale Henrichs" <dhenrich@vmware.com> | To: Pharo-project@lists.gforge.inria.fr | Sent: Saturday, March 10, 2012 5:53:52 PM | Subject: Re: [Pharo-project] Can we change diff-generator to ignore white-space diffs? | | formatted source code doesn't show up as different anyway? | | ----- Original Message ----- | | From: "Dale Henrichs" <dhenrich@vmware.com> | | To: Pharo-project@lists.gforge.inria.fr | | Sent: Saturday, March 10, 2012 5:53:01 PM | | Subject: Re: [Pharo-project] Can we change diff-generator to ignore | | white-space diffs? | | | | "ignoring whitespace" means? | | | | ----- Original Message ----- | | | From: "Igor Stasenko" <siguctua@gmail.com> | | | To: Pharo-project@lists.gforge.inria.fr | | | Sent: Saturday, March 10, 2012 5:44:39 PM | | | Subject: Re: [Pharo-project] Can we change diff-generator to | | | ignore | | | white-space diffs? | | | | | | On 11 March 2012 02:27, Dale Henrichs <dhenrich@vmware.com> | | | wrote: | | | > An approach that I've used in the past is to use a formatter | | | > both | | | > sides of the comparison ... | | | > | | | | | | Well, the point is that formatting changes are visible without | | | any | | | highlighting. | | | And if you will use formatter, then you won't see that guy | | | actually | | | just (re)formatted code. | | | | | | > Dale | | | > | | | > ----- Original Message ----- | | | > | From: "Igor Stasenko" <siguctua@gmail.com> | | | > | To: "Pharo Development" <Pharo-project@lists.gforge.inria.fr> | | | > | Sent: Saturday, March 10, 2012 5:21:28 PM | | | > | Subject: [Pharo-project] Can we change diff-generator to | | | > | ignore | | | > | white-space  diffs? | | | > | | | | > | Because it makes things unreadable. | | | > | Here, i replaced spaces with tabs.. and see what happens. | | | > | | | | > | | | | > | -- | | | > | Best regards, | | | > | Igor Stasenko. | | | > | | | | > | | | | | | | | | | | | -- | | | Best regards, | | | Igor Stasenko. | | | | | | | | | | | |
-- Best regards, Igor Stasenko.
Igor Stasenko wrote:
Because it makes things unreadable. Here, i replaced spaces with tabs.. and see what happens.
Similiarly... I am finding that as I am digging into it the system to learn it by scattering 'self halts' through the code and later deleting them, often the whitespace it not identical to the original and when reviewing <changes> in the Monticello Browser these these are annoying to have listed as changes. What do you think of the Monticello <changes> button ignoring whitespace? cheers, -ben
On 12 March 2012 15:33, Ben Coman <btc@openinworld.com> wrote:
Igor Stasenko wrote:
Because it makes things unreadable. Here, i replaced spaces with tabs.. and see what happens.
Similiarly... I am finding that as I am digging into it the system to learn it by scattering 'self halts' through the code and later deleting them, Â often the whitespace it not identical to the original and when reviewing <changes> in the Monticello Browser these these are annoying to have listed as changes. Â What do you think of the Monticello <changes> button ignoring whitespace?
i think yes. :)
cheers, -ben
-- Best regards, Igor Stasenko.
On 12.03.2012 15:33, Ben Coman wrote:
Igor Stasenko wrote:
Because it makes things unreadable. Here, i replaced spaces with tabs.. and see what happens.
Similiarly... I am finding that as I am digging into it the system to learn it by scattering 'self halts' through the code and later deleting them, often the whitespace it not identical to the original and when reviewing <changes> in the Monticello Browser these these are annoying to have listed as changes. What do you think of the Monticello <changes> button ignoring whitespace?
cheers, -ben
Presumably, the method timestamp changed as well, and a new MC version would be saved with your credentials / current time... For these cases, I find it best to use "Show versions... " then revert to the old definition. Cheers, Henry
participants (4)
-
Ben Coman -
Dale Henrichs -
Henrik Sperre Johansen -
Igor Stasenko