[Pharo-project] Fixing the StackInterpreterSimulator for Pharo 1.4
Hi: The attached change set fixes bit rot in the StackInterpreterSimulator and related classes. Here a brief summary: - VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr` For the last change, I wonder whether that's going to work, because that code is going to be translated to C, right? Is anyone interest in these changes? Should I also fix the other simulators? With them, I can load a Pharo 1.2.1 image in the simulator, I wasn't patient enough to wait for a 1.4 image to complete loading. | sim | InterpreterStackPage initialize. sim := StackInterpreterSimulator new. sim openOn: '/.../Downloads/Pharo-1.2.1-11.04.03/Pharo-1.2.1.image'. sim openAsMorph. [ sim run ] fork. Best regards Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
Hi:
The attached change set fixes bit rot in the StackInterpreterSimulator and related classes.
Here a brief summary:
- VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr`
For the last change, I wonder whether that's going to work, because that code is going to be translated to C, right?
Is anyone interest in these changes?
yes!
Should I also fix the other simulators?
it would be great!
With them, I can load a Pharo 1.2.1 image in the simulator, I wasn't patient enough to wait for a 1.4 image to complete loading.
| sim | InterpreterStackPage initialize. sim := StackInterpreterSimulator new. sim openOn: '/.../Downloads/Pharo-1.2.1-11.04.03/Pharo-1.2.1.image'. sim openAsMorph. [ sim run ] fork.
Best regards Stefan
<Fix simulator.1.cs> -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
Hi: On 06 Nov 2012, at 17:59, Stéphane Ducasse wrote:
The attached change set fixes bit rot in the StackInterpreterSimulator and related classes.
Here a brief summary:
- VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr`
Here are more complete patch. Into which tracker should that go? CogVM or Pharo? Best regards Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
On 8 November 2012 14:16, Stefan Marr <smalltalk@stefan-marr.de> wrote:
Hi:
On 06 Nov 2012, at 17:59, Stéphane Ducasse wrote:
The attached change set fixes bit rot in the StackInterpreterSimulator and related classes.
Here a brief summary:
- VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr`
Here are more complete patch.
Into which tracker should that go? CogVM or Pharo?
the build job? https://ci.lille.inria.fr/pharo/view/Cog/job/Cog%20Git%20Tracker/
Best regards Stefan
-- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
-- Best regards, Igor Stasenko.
he means in which tracker does he put the issue, so it can be integrated, I suppose. if is that, is in cog tracker: http://code.google.com/p/cog/issues/list Esteban On Nov 9, 2012, at 10:50 AM, Igor Stasenko <siguctua@gmail.com> wrote:
On 8 November 2012 14:16, Stefan Marr <smalltalk@stefan-marr.de> wrote:
Hi:
On 06 Nov 2012, at 17:59, Stéphane Ducasse wrote:
The attached change set fixes bit rot in the StackInterpreterSimulator and related classes.
Here a brief summary:
- VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr`
Here are more complete patch.
Into which tracker should that go? CogVM or Pharo?
the build job?
https://ci.lille.inria.fr/pharo/view/Cog/job/Cog%20Git%20Tracker/
Best regards Stefan
-- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
-- Best regards, Igor Stasenko.
On 9 November 2012 07:01, Esteban Lorenzano <estebanlm@gmail.com> wrote:
he means in which tracker does he put the issue, so it can be integrated, I suppose.
if is that, is in cog tracker: http://code.google.com/p/cog/issues/list
yes, i think this is best one
Esteban
On Nov 9, 2012, at 10:50 AM, Igor Stasenko <siguctua@gmail.com> wrote:
On 8 November 2012 14:16, Stefan Marr <smalltalk@stefan-marr.de> wrote:
Hi:
On 06 Nov 2012, at 17:59, Stéphane Ducasse wrote:
The attached change set fixes bit rot in the StackInterpreterSimulator and related classes.
Here a brief summary:
- VMClass>>#doOrDefer: now uses ProcessBrowser>>#isUIProcess: instead of Project - it replaces the use of #asDisplayText with StringMorph>>#contents:. - use of ThreadStream>>#on: is replaced with ThreadSafeTranscript>>#new - Utilities is replaced by UIManager>>#default - and #primitiveGetAttribute now uses the non-depricated `Smalltalk vm getSystemAttribute: attr`
Here are more complete patch.
Into which tracker should that go? CogVM or Pharo?
the build job?
https://ci.lille.inria.fr/pharo/view/Cog/job/Cog%20Git%20Tracker/
Best regards Stefan
-- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 2974 Fax: +32 2 629 3525
-- Best regards, Igor Stasenko.
-- Best regards, Igor Stasenko.
participants (4)
-
Esteban Lorenzano -
Igor Stasenko -
Stefan Marr -
Stéphane Ducasse