[Pharo-project] Funky BalloonMorph
The balloon morph color and layout mess really give a bad bad feeling, I gave a look to try to fix it: * COLOR, it seems to be just an initialize issue, one should execute this in the image: BalloonMorph setBalloonColorTo: BalloonMorph defaultBalloonColor. * FONT, same problem, one should execute in the image : BalloonMorph balloonFont: StandardFonts defaultFont. * LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job. Moreover this method need to be refactored to be readable, it is too looooong. Jannick can you give a try, you seem to be the author? Hilaire
ok hiliare open a ticket and put an initialize. Stef On May 14, 2011, at 3:29 PM, Hilaire Fernandes wrote:
The balloon morph color and layout mess really give a bad bad feeling,
I gave a look to try to fix it:
* COLOR, it seems to be just an initialize issue, one should execute this in the image:
BalloonMorph setBalloonColorTo: BalloonMorph defaultBalloonColor.
* FONT, same problem, one should execute in the image :
BalloonMorph balloonFont: StandardFonts defaultFont.
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Moreover this method need to be refactored to be readable, it is too looooong. Jannick can you give a try, you seem to be the author?
Hilaire
I added the BalloonMorph class>>initialize in the same ticket http://code.google.com/p/pharo/issues/detail?id=3694 Steph, can you recall me if the class initialize method is called automatically at start up or something like that or does it need to be called manually? Hilaire Le 14/05/2011 15:36, Stéphane Ducasse a écrit :
ok hiliare open a ticket and put an initialize.
Stef
On May 14, 2011, at 3:29 PM, Hilaire Fernandes wrote:
The balloon morph color and layout mess really give a bad bad feeling,
I gave a look to try to fix it:
* COLOR, it seems to be just an initialize issue, one should execute this in the image:
BalloonMorph setBalloonColorTo: BalloonMorph defaultBalloonColor.
* FONT, same problem, one should execute in the image :
BalloonMorph balloonFont: StandardFonts defaultFont.
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Moreover this method need to be refactored to be readable, it is too looooong. Jannick can you give a try, you seem to be the author?
Hilaire
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior: 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40 -> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
did you check if the squeak version has the same behavior? Stef On May 14, 2011, at 3:49 PM, Hilaire Fernandes wrote:
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior:
'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40
-> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
Not yet Hilaire Le 14/05/2011 15:56, Stéphane Ducasse a écrit :
did you check if the squeak version has the same behavior?
Stef
On May 14, 2011, at 3:49 PM, Hilaire Fernandes wrote:
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior:
'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40
-> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
http://code.google.com/p/pharo/issues/detail?id=2704 in Pharo 1.3 2011/5/14 Hilaire Fernandes <hilaire.fernandes@gmail.com>:
Not yet
Hilaire
Le 14/05/2011 15:56, Stéphane Ducasse a écrit :
did you check if the squeak version has the same behavior?
Stef
On May 14, 2011, at 3:49 PM, Hilaire Fernandes wrote:
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior:
'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40
-> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
Andreas fixed that not so long ago, and I thought I had posted a fix for Pharo too Nicolas 2011/5/14 Stéphane Ducasse <stephane.ducasse@inria.fr>:
did you check if the squeak version has the same behavior?
Stef
On May 14, 2011, at 3:49 PM, Hilaire Fernandes wrote:
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior:
'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40
-> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
Right, I also saw that. I have added the need info and changeset in this report: http://code.google.com/p/pharo/issues/detail?id=3694&q=balloon&colspec=ID%20... Hilaire Le 14/05/2011 15:58, Nicolas Cellier a écrit :
Andreas fixed that not so long ago, and I thought I had posted a fix for Pharo too
Nicolas
2011/5/14 Stéphane Ducasse <stephane.ducasse@inria.fr>:
did you check if the squeak version has the same behavior?
Stef
On May 14, 2011, at 3:49 PM, Hilaire Fernandes wrote:
Le 14/05/2011 15:29, Hilaire Fernandes a écrit :
* LAYOUT, the problem comes from the method String>>withNoLineLongerThan: doing very badly its job.
Example of unexpected behavior:
'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte' withNoLineLongerThan: 40
-> 'un exemple de texte pour ici qui devrait etre facile a mettre en oeuvre dans ce petit texte'
participants (3)
-
Hilaire Fernandes -
Nicolas Cellier -
Stéphane Ducasse