Please Review Issue 12592: Text Embedded Morphs Broken
Fix in inbox: SLICE-Issue-12592-Text-Embedded-Morphs-Broken-SeanDeNigris.1 The following causes a DNU without the fix, works after: text := (Text withAll: 'foo') , (Text string: (Character value: 1) asString attribute: (TextAnchor new anchoredMorph: Smalltalk ui icons confirmIcon)) , (Text withAll: 'bar'). text asMorph openInHand Waiting for answer from Nico Cellier on squeak dev (see http://forum.world.st/Text-Morph-Embedding-Broken-td4735055.html) as to why you can't add a TextAnchor to Text with an arbitrary string anymore, but I'll make a new issue for that if necessary ----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-Review-Issue-12592-Text-Embedded-Morphs-Broken-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
2014/1/8 Sean P. DeNigris <sean@clipperadams.com>
Fix in inbox: SLICE-Issue-12592-Text-Embedded-Morphs-Broken-SeanDeNigris.1
The following causes a DNU without the fix, works after: text := (Text withAll: 'foo') , (Text string: (Character value: 1) asString attribute: (TextAnchor new anchoredMorph: Smalltalk ui icons confirmIcon)) , (Text withAll: 'bar'). text asMorph openInHand
Waiting for answer from Nico Cellier on squeak dev (see http://forum.world.st/Text-Morph-Embedding-Broken-td4735055.html) as to why you can't add a TextAnchor to Text with an arbitrary string anymore, but I'll make a new issue for that if necessary
----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-Review-Issue-12592-Text-Embedded-Morphs-Broken-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Your fix works for the DNU , but the issue description is a bit misleading. If someone reads the top most description and then tests your fix, he still can not see an icon.
Nicolai Hess wrote
Your fix works for the DNU , but the issue description is a bit misleading. If someone reads the top most description and then tests your fix, he still can not see an icon.
I see what you mean⦠Per Nico Cellier on squeak dev (see http://forum.world.st/Text-Morph-Embedding-Broken-td4735055.html), requiring TextAnchors to be on Text with "(Character value: 1) asString" strings only (e.g. no more "Text string: '*' attribute: aTextAnchorâ¦") is intended. I opened "Case 12596: Clarify new TextAnchor usage" to clarify new behavior ----- Cheers, Sean -- View this message in context: http://forum.world.st/Please-Review-Issue-12592-Text-Embedded-Morphs-Broken-... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (2)
-
Nicolai Hess -
Sean P. DeNigris