Re: [Pharo-project] [update 1.2] #12170
aMethod is a selector. so we should change the code and like that the tests get green :). Stef
Henrik
when I drop a cs I get a DNU. No time to check now.
Stef On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote:
From: stephane ducasse <stephane.ducasse@gmail.com> Date: October 5, 2010 11:43:17 AM GMT+02:00 To: An open mailing list to discuss any topics related to an open-source Smalltalk <Pharo-project@lists.gforge.inria.fr> Subject: [update 1.2] #12170
12170 -----
- Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I got an error when building PharoKernel too: 9 MessageNotUnderstood(Exception)>>signal 10 UndefinedObject(Object)>>doesNotUnderstand: #selector 11 RecategorizedEvent class>>method:protocol:class:oldProtocol: 12 SystemChangeNotifier>>selector:recategorizedFrom:to:inClass: 13 Metaclass(ClassDescription)>>notifyOfRecategorizedSelector:from:to: 14 ClassOrganizer>>notifyOfChangedSelector:from:to: 15 ClassOrganizer>>removeElement: and the version from your comment ^(self method: aMethod protocol: prot class: aClass) itemSelector: aMethod; oldCategory: oldName doesn't solve the fix -- Pavel On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
aMethod is a selector.
so we should change the code and like that the tests get green :).
Stef
Henrik
when I drop a cs I get a DNU. No time to check now.
Stef On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote:
From: stephane ducasse <stephane.ducasse@gmail.com> Date: October 5, 2010 11:43:17 AM GMT+02:00 To: An open mailing list to discuss any topics related to an
open-source Smalltalk <Pharo-project@lists.gforge.inria.fr>
Subject: [update 1.2] #12170
12170 -----
- Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
So aMethod parameter can be either CompiledMethod (method recategorization), nil (when building core), or a selector (dropping cs). Makes total sense... :P Cheers, Henry On Oct 5, 2010, at 12:03 22PM, Stéphane Ducasse wrote:
aMethod is a selector.
so we should change the code and like that the tests get green :).
Stef
Henrik
when I drop a cs I get a DNU. No time to check now.
Stef On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote:
From: stephane ducasse <stephane.ducasse@gmail.com> Date: October 5, 2010 11:43:17 AM GMT+02:00 To: An open mailing list to discuss any topics related to an open-source Smalltalk <Pharo-project@lists.gforge.inria.fr> Subject: [update 1.2] #12170
12170 -----
- Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi, On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
aMethod is a selector.
aMethod is a CompiledMethod or nil (when the method is deleted) -- Pavel
so we should change the code and like that the tests get green :).
Stef
Henrik
when I drop a cs I get a DNU. No time to check now.
Stef On Oct 5, 2010, at 11:51 AM, Stéphane Ducasse wrote:
From: stephane ducasse <stephane.ducasse@gmail.com> Date: October 5, 2010 11:43:17 AM GMT+02:00 To: An open mailing list to discuss any topics related to an
open-source Smalltalk <Pharo-project@lists.gforge.inria.fr>
Subject: [update 1.2] #12170
12170 -----
- Issue 3060: Update Monticello to detect method recategorization correctly. Thanks Pavel Krivanek and Henrik Johanssen
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Oct 5, 2010, at 12:25 37PM, Pavel Krivanek wrote:
Hi,
On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: aMethod is a selector.
aMethod is a CompiledMethod or nil (when the method is deleted)
-- Pavel
Submitted new slice, this time deprecating old constructor, and using a new one passing the selector explicitly, seeing as how method (or nil) was inferred based on it in the first place. Of course, an alternative is to just set itemSelector if method notNil, the choice simply reflects my personal preference. Cheers, Henry
2010/10/5 Henrik Johansen <henrik.s.johansen@veloxit.no>
On Oct 5, 2010, at 12:25 37PM, Pavel Krivanek wrote:
Hi,
On Tue, Oct 5, 2010 at 12:03 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
aMethod is a selector.
aMethod is a CompiledMethod or nil (when the method is deleted)
-- Pavel
Submitted new slice, this time deprecating old constructor, and using a new one passing the selector explicitly, seeing as how method (or nil) was inferred based on it in the first place. Of course, an alternative is to just set itemSelector if method notNil, the choice simply reflects my personal preference.
Cheers, Henry
Good solution, thanks... -- Pavel
participants (3)
-
Henrik Johansen -
Pavel Krivanek -
Stéphane Ducasse