Thanks I will integrate it in the next batch. I have some fixes when working on Bloc with Alain. His code is much nicer but it requires some work. Stef On 4/6/14 02:40, Esteban Lorenzano wrote:

https://pharo.fogbugz.com/f/cases/13302/

and is also backported to the dark theme for Pharo3 (in my repository)

Esteban

On 03 Jun 2014, at 16:20, Nicolai Hess <nicolaihess@web.de> wrote:

...

2014-06-03 20:18 GMT+02:00 phil@highoctane.be <mailto:phil@highoctane.be> <phil@highoctane.be <mailto:phil@highoctane.be>>:

When showing the world menu, there is an issue with the Dark Themes.

MenuMorph>>drawOn: aCanvas "Draw the menu. Add keyboard-focus feedback if appropriate"

super drawOn: aCanvas.

(ActiveHand notNil and: [ActiveHand keyboardFocus == self and: [self rootMenu hasProperty: #hasUsedKeyboard]]) ifTrue: [ aCanvas frameAndFillRectangle: self innerBounds fillColor: Color transparent borderWidth: self theme menuBorderWidth borderColor: self theme menuKeyboardFocusColor ].

looks for

menuBorderWidth and menuKeyboardFocusColor.

When hitting a key that doesn't exists in the menu, I had the redcross.

Defining the methods solved it.

Thanks for fixing the themes.

Phil

This happens for the non dark Pharo3Theme too. And in the latest pharo40, only menuKeyboardFocusColor is missing. The menuBorderWidth method is defined in UITheme.

nicolai