shortcut change in pharo 50075
in pharo 50075 some shortcuts are removed (issue 15630 <https://pharo.fogbugz.com/default.asp?15630> Remove duplicate shortcut definition (TextEditors actionMap vs KM)) This is by intention. They were defined in text editors action maps and with the Keymapping framework (pragma keymap). Those were defined with two different "command"-keys (alt and ctrl). This change is not yet visible, although I defined a postload you will see the change only after TextEditor/SmalltalkEditior initialize (all alt+ shortcut are removed now, only the ctrl+ shortcuts should work) alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find Some "duplicate" shortcuts weren't removed because the shortcut defined with the keymap pragma don't work (at least on windows). For example: ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm please test the 50075 image, reinitialize editors subclasses and give feedback (linux and mac users too). thank you nicolai
Thanks nicolas. What we are trying to do (not easy) is to use rubric for texteditor with the idea that it will be easier to migrate to Bloc. Stef Le 30/5/15 11:45, Nicolai Hess a écrit :
in pharo 50075 some shortcuts are removed (issue 15630 <https://pharo.fogbugz.com/default.asp?15630> Remove duplicate shortcut definition (TextEditors actionMap vs KM))
This is by intention. They were defined in text editors action maps and with the Keymapping framework (pragma keymap).
Those were defined with two different "command"-keys (alt and ctrl).
This change is not yet visible, although I defined a postload you will see the change only after TextEditor/SmalltalkEditior initialize
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
Some "duplicate" shortcuts weren't removed because the shortcut defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
please test the 50075 image, reinitialize editors subclasses and give feedback (linux and mac users too).
thank you
nicolai
Hi, Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7 This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different: - alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work Some "duplicate" shortcuts weren't removed because the shortcut
defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
True, ctr-m does not work on win. Thanks for your work Nicolai. Best, Mark
2015-05-31 10:43 GMT+02:00 Mark Rizun <mrizun@gmail.com>:
Hi,
Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7
Thank you for your feedback
This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different:
- alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work
Yes, rubrics text components using their own shortcut/action maps.
Hi, I think test into the playground is a bad idea because the playground is a GTool and glamour has his own shortcut system. Also I think Playground use Rubric and not TextEditor/Smalltalk Editor. Do you know where text/smalltalk editor are used Nicolas ? Le dimanche 31 mai 2015, Mark Rizun <mrizun@gmail.com> a écrit :
Hi,
Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7
This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different:
- alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work
Some "duplicate" shortcuts weren't removed because the shortcut
defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
True, ctr-m does not work on win.
Thanks for your work Nicolai.
Best, Mark
-- Cheers Cyril Ferlicot
2015-05-31 14:34 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
Hi, I think test into the playground is a bad idea because the playground is a GTool and glamour has his own shortcut system. Also I think Playground use Rubric and not TextEditor/Smalltalk Editor.
Do you know where text/smalltalk editor are used Nicolas ?
Nautilus, old workspace (Workspace new open), MessageBrowser (Textpane in sendersOf/implementorsOf/usersOf - results list). And of course, you can create a TextMorph that uses those editors: "This creates a simple text morph with editor #TextEditor" (Smalltalk ui theme builder newBasicTextEditorFor: Morph getText: #comment setText: nil) openInWindow. "This creates a smalltalk text morph with editor #SmalltalkEditor" (Smalltalk ui theme builder newTextEditorFor: (Morph>>#drawOn:) getText: #sourceCode setText: nil) openInWindow. nicolai
Le dimanche 31 mai 2015, Mark Rizun <mrizun@gmail.com> a écrit :
Hi,
Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7
This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different:
- alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work
Some "duplicate" shortcuts weren't removed because the shortcut
defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
True, ctr-m does not work on win.
Thanks for your work Nicolai.
Best, Mark
-- Cheers Cyril Ferlicot
Is there a way to customize/change the base shortcut for Linux? I find it much more comfortable to use LAlt as my finger is right next to it compared to Control. Considering PharoShortcuts explicitly states that it should be ctrl `($o ctrl , $w ctrl) unix`, I'm assuming the only way would be to rewrite the methods? Peter On Sun, May 31, 2015 at 4:17 PM, Nicolai Hess <nicolaihess@web.de> wrote:
2015-05-31 14:34 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
Hi, I think test into the playground is a bad idea because the playground is a GTool and glamour has his own shortcut system. Also I think Playground use Rubric and not TextEditor/Smalltalk Editor.
Do you know where text/smalltalk editor are used Nicolas ?
Nautilus, old workspace (Workspace new open), MessageBrowser (Textpane in sendersOf/implementorsOf/usersOf - results list).
And of course, you can create a TextMorph that uses those editors:
"This creates a simple text morph with editor #TextEditor" (Smalltalk ui theme builder newBasicTextEditorFor: Morph getText: #comment setText: nil) openInWindow.
"This creates a smalltalk text morph with editor #SmalltalkEditor" (Smalltalk ui theme builder newTextEditorFor: (Morph>>#drawOn:) getText: #sourceCode setText: nil) openInWindow.
nicolai
Le dimanche 31 mai 2015, Mark Rizun <mrizun@gmail.com> a écrit :
Hi,
Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7
This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different:
- alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work
Some "duplicate" shortcuts weren't removed because the shortcut
defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
True, ctr-m does not work on win.
Thanks for your work Nicolai.
Best, Mark
-- Cheers Cyril Ferlicot
2015-05-31 23:09 GMT+02:00 Peter Uhnák <i.uhnak@gmail.com>:
Is there a way to customize/change the base shortcut for Linux? I find it much more comfortable to use LAlt as my finger is right next to it compared to Control.
Not yet.
Considering PharoShortcuts explicitly states that it should be ctrl `($o ctrl , $w ctrl) unix`, I'm assuming the only way would be to rewrite the methods?
I hope we change that in PharoShortcuts, we should use one "Meta/Command" key name, that is mapped to Ctrl for win/linux and Cmd fo mac
Peter
On Sun, May 31, 2015 at 4:17 PM, Nicolai Hess <nicolaihess@web.de> wrote:
2015-05-31 14:34 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
Hi, I think test into the playground is a bad idea because the playground is a GTool and glamour has his own shortcut system. Also I think Playground use Rubric and not TextEditor/Smalltalk Editor.
Do you know where text/smalltalk editor are used Nicolas ?
Nautilus, old workspace (Workspace new open), MessageBrowser (Textpane in sendersOf/implementorsOf/usersOf - results list).
And of course, you can create a TextMorph that uses those editors:
"This creates a simple text morph with editor #TextEditor" (Smalltalk ui theme builder newBasicTextEditorFor: Morph getText: #comment setText: nil) openInWindow.
"This creates a smalltalk text morph with editor #SmalltalkEditor" (Smalltalk ui theme builder newTextEditorFor: (Morph>>#drawOn:) getText: #sourceCode setText: nil) openInWindow.
nicolai
Le dimanche 31 mai 2015, Mark Rizun <mrizun@gmail.com> a écrit :
Hi,
Tested in image: 50077 (hope it's not very critical to test on 50075) OS: Win 7
This change is not yet visible, although I defined a postload
you will see the change only after TextEditor/SmalltalkEditior initialize
Ok, I did TextEditor/SmalltalkEditior initialize.
(all alt+ shortcut are removed now, only the ctrl+ shortcuts should work)
alt+space / ctrl+space -> select word alt+b/ctrl+b browseIt alt+c/ctrl+c copy alt+x/ctrl+x cut alt+v/ctrl+v paste alt+f/ctrl+f find
In playground for me all of the above alt shortcuts work. As well as ctr. In system browser it's different:
- alt-space, alt-b, alt-f does not work - all the others work (c, v, x) - all of above ctr shortcuts work
Some "duplicate" shortcuts weren't removed because the shortcut
defined with the keymap pragma don't work (at least on windows).
For example:
ctrl+a/alt+a defined with the action map and ctrl+a defined by keymap pragam this wasn't remove, because ctrl+a does not work on windows vm
ctrl+m/alt+m defined by the action map ctrl+m defined by keymap pragma this wasn't remove, because ctrl+m does not work on windows vm
True, ctr-m does not work on win.
Thanks for your work Nicolai.
Best, Mark
-- Cheers Cyril Ferlicot
Nicolai Hess wrote
I hope we change that in PharoShortcuts, we should use one "Meta/Command" key name, that is mapped to Ctrl for win/linux and Cmd fo mac
After re-reading the key descriptions on Wikipedia: http://en.wikipedia.org/wiki/Meta_key http://en.wikipedia.org/wiki/Command_key http://en.wikipedia.org/wiki/Windows_key IMO #meta is the only sensible name for "the appropriate key on Xyz platform", as it is not in use by modern keyboards and thus can be thought of abstractly. Command, which I too initially thought might work, doesn't seem like a great candidate because it means cmd on Mac ("command" is written on the key on my Macbook Air), so Windows users may naturally think that translates to the Win key, which appears in the same place on Windows keyboards, but serves a somewhat different function. ----- Cheers, Sean -- View this message in context: http://forum.world.st/shortcut-change-in-pharo-50075-tp4829460p4829746.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Mon, Jun 1, 2015 at 6:35 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Nicolai Hess wrote
I hope we change that in PharoShortcuts, we should use one "Meta/Command" key name, that is mapped to Ctrl for win/linux and Cmd fo mac
After re-reading the key descriptions on Wikipedia: http://en.wikipedia.org/wiki/Meta_key http://en.wikipedia.org/wiki/Command_key http://en.wikipedia.org/wiki/Windows_key IMO #meta is the only sensible name for "the appropriate key on Xyz platform", as it is not in use by modern keyboards and thus can be thought of abstractly. Command, which I too initially thought might work, doesn't seem like a great candidate because it means cmd on Mac ("command" is written on the key on my Macbook Air), so Windows users may naturally think that translates to the Win key, which appears in the same place on Windows keyboards, but serves a somewhat different function.
This was my concern also. btw, I found this an interesting read... https://www.mozilla.org/access/keyboard/ cheers -ben
2015-06-01 15:31 GMT+02:00 Ben Coman <btc@openinworld.com>:
On Mon, Jun 1, 2015 at 6:35 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
Nicolai Hess wrote
I hope we change that in PharoShortcuts, we should use one "Meta/Command" key name, that is mapped to Ctrl for win/linux and Cmd fo mac
After re-reading the key descriptions on Wikipedia: http://en.wikipedia.org/wiki/Meta_key http://en.wikipedia.org/wiki/Command_key http://en.wikipedia.org/wiki/Windows_key IMO #meta is the only sensible name for "the appropriate key on Xyz platform", as it is not in use by modern keyboards and thus can be thought of abstractly. Command, which I too initially thought might work, doesn't seem like a great candidate because it means cmd on Mac ("command" is written on the key on my Macbook Air), so Windows users may naturally think that translates to the Win key, which appears in the same place on Windows keyboards, but serves a somewhat different function.
This was my concern also. btw, I found this an interesting read... https://www.mozilla.org/access/keyboard/
I would choose "Command" because some documentation around squeak/pharo use the term command-click/command+char even though the "command+key" only exists for mac. But I am happy with any decision. We just need someone to take this decision (looking at the main developer of the Keymapping framework) nicolai
cheers -ben
I like meta because there is no concrete "meta" key, so it's less confusing. Command means something to mac users but nothing to windows/unix users. And then, what should think somebody who knows both systems? Regarding documentation, even if we have documentation in the wild that specifies "Command", then we should explain that "Command" means Control in Windows and Linux. So changing the documentation is inevitable. El mar., 9 de jun. de 2015 a la(s) 8:37 a. m., Nicolai Hess < nicolaihess@web.de> escribió:
2015-06-01 15:31 GMT+02:00 Ben Coman <btc@openinworld.com>:
On Mon, Jun 1, 2015 at 6:35 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
This was my concern also. btw, I found this an interesting read... https://www.mozilla.org/access/keyboard/
Nice write up!
2015-06-09 16:32 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
I like meta because there is no concrete "meta" key, so it's less confusing. Command means something to mac users but nothing to windows/unix users. And then, what should think somebody who knows both systems?
Ok, I take this as a decision! :) That would mean we remove the current delegatedModifier implementation from KMCommandModifier and move it to KMMetaModifier, right?
Regarding documentation, even if we have documentation in the wild that specifies "Command", then we should explain that "Command" means Control in Windows and Linux. So changing the documentation is inevitable.
El mar., 9 de jun. de 2015 a la(s) 8:37 a. m., Nicolai Hess < nicolaihess@web.de> escribió:
2015-06-01 15:31 GMT+02:00 Ben Coman <btc@openinworld.com>:
On Mon, Jun 1, 2015 at 6:35 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
This was my concern also. btw, I found this an interesting read... https://www.mozilla.org/access/keyboard/
Nice write up!
El mié., 10 de jun. de 2015 a la(s) 11:20 a. m., Nicolai Hess < nicolaihess@web.de> escribió:
2015-06-09 16:32 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
I like meta because there is no concrete "meta" key, so it's less confusing. Command means something to mac users but nothing to windows/unix users. And then, what should think somebody who knows both systems?
Ok, I take this as a decision! :)
That would mean we remove the current delegatedModifier implementation from KMCommandModifier and move it to KMMetaModifier, right?
I did not know any delegatedModifier O_o. Wow, the code evolves by itself as soon as it gets integrated in Pharo, haha! This morning we fixed the bug that made KMMetaModifier not work on windows. I'll check the delegated modifier later this afternoon. This package needs a cleanup...
Regarding documentation, even if we have documentation in the wild that specifies "Command", then we should explain that "Command" means Control in Windows and Linux. So changing the documentation is inevitable.
El mar., 9 de jun. de 2015 a la(s) 8:37 a. m., Nicolai Hess < nicolaihess@web.de> escribió:
2015-06-01 15:31 GMT+02:00 Ben Coman <btc@openinworld.com>:
On Mon, Jun 1, 2015 at 6:35 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
This was my concern also. btw, I found this an interesting read... https://www.mozilla.org/access/keyboard/
Nice write up!
Nicolai Hess wrote
I like meta because there is no concrete "meta" key, so it's less confusing Ok, I take this as a decision!
Great :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/shortcut-change-in-pharo-50075-tp4829460p4831396.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (8)
-
Ben Coman -
Cyril Ferlicot -
Guillermo Polito -
Mark Rizun -
Nicolai Hess -
Peter Uhnák -
Sean P. DeNigris -
stepharo