instance variable rename is deeply broken....
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :( Mark do you know if your changes go integrated? Because now I will work without refactoring and I have all the spec classes to change. Not fun. Stef
On 26 Feb 2015, at 16:12, stepharo <stepharo@free.fr> wrote:
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :(
Mark do you know if your changes go integrated?
His changes where integrated, the undo of this not. Yes, we should remove this...
Because now I will work without refactoring and I have all the spec classes to change. Not fun.
Stef
rename: aVarName to: aName in: aClass self rename: aVarName to: aName in: aClass renameAccessors: false ^^^^^ (false makes sure that there is no renaming).
On 26 Feb 2015, at 16:12, stepharo <stepharo@free.fr> wrote:
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :(
Mark do you know if your changes go integrated? His changes where integrated, the undo of this not. Yes, we should remove this...
I did not get the undo. But in my image renaming a variables renames the accessors and more. To work I modified to put false instead of true. rename: aVarName to: aName in: aClass self rename: aVarName to: aName in: aClass renameAccessors: false I can prepare a slice to either remove the behavior or at least turn it off.
Because now I will work without refactoring and I have all the spec classes to change. Not fun.
Stef
Marcus I browse the changes of the previous version of the refactoring package core containing the refactoring definition and I could not find anythiong. this is strange because it was before mark left. Le 26/2/15 16:15, Marcus Denker a écrit :
On 26 Feb 2015, at 16:12, stepharo <stepharo@free.fr> wrote:
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :(
Mark do you know if your changes go integrated? His changes where integrated, the undo of this not. Yes, we should remove this...
Because now I will work without refactoring and I have all the spec classes to change. Not fun.
Stef
On 26 Feb 2015, at 16:36, stepharo <stepharo@free.fr> wrote:
Marcus I browse the changes of the previous version of the refactoring package core containing the refactoring definition and I could not find anythiong. this is strange because it was before mark left.
Yes, but two things happened at once: one issue was proposing to add a flag, one issue to remove the whole mechanism. As I did not realise that it was broken, I integrated the flag, not the removal. Marcus
Le 26/2/15 16:15, Marcus Denker a écrit :
On 26 Feb 2015, at 16:12, stepharo <stepharo@free.fr> wrote:
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :(
Mark do you know if your changes go integrated? His changes where integrated, the undo of this not. Yes, we should remove this...
Because now I will work without refactoring and I have all the spec classes to change. Not fun.
Stef
Ok Let me know if you need me. I'm teaching from 6 to 9. Le 26/2/15 16:39, Marcus Denker a écrit :
On 26 Feb 2015, at 16:36, stepharo <stepharo@free.fr> wrote:
Marcus I browse the changes of the previous version of the refactoring package core containing the refactoring definition and I could not find anythiong. this is strange because it was before mark left.
Yes, but two things happened at once: one issue was proposing to add a flag, one issue to remove the whole mechanism. As I did not realise that it was broken, I integrated the flag, not the removal.
Marcus
Le 26/2/15 16:15, Marcus Denker a écrit :
On 26 Feb 2015, at 16:12, stepharo <stepharo@free.fr> wrote:
This was a BAD IDEA to rename naively accessors when we rename an instance variable. Now I cannot use instance renaming because of the ripple effects I do not control. And I just got an emergency evaluator when I simply wanted to rename an instance variable in ButtonModel :(
Mark do you know if your changes go integrated? His changes where integrated, the undo of this not. Yes, we should remove this...
Because now I will work without refactoring and I have all the spec classes to change. Not fun.
Stef
participants (2)
-
Marcus Denker -
stepharo