hi all, In a fresh image #30826, I tried: Smalltalk image condenseChanges -> ZnInvalidUTF8 error https://pharo.fogbugz.com/default.asp?12729& describes that but it is closed. I tried the new version: PharoChangesCondenser condense. -> parse error Do we open a new bug? Is there another way that I missed? Do you agree that we should remove condenseChanges from SmalltalkImage? Cheers, #Luc
On 17 Apr 2014, at 21:13, Luc Fabresse <luc.fabresse@gmail.com> wrote:
I tried the new version:
PharoChangesCondenser condense. -> parse error
I tried recently and it just worked.
Do we open a new bug?
Yes
Is there another way that I missed?
Do you agree that we should remove condenseChanges from SmalltalkImage?
Maybe not just yet ;-)
On 17 Apr 2014, at 21:13, Luc Fabresse <luc.fabresse@gmail.com> wrote:
hi all,
In a fresh image #30826, I tried:
Smalltalk image condenseChanges -> ZnInvalidUTF8 error
https://pharo.fogbugz.com/default.asp?12729& describes that but it is closed.
I tried the new version:
PharoChangesCondenser condense. -> parse error
Works fine for me. No error.
Do we open a new bug?
Is there another way that I missed?
Do you agree that we should remove condenseChanges from SmalltalkImage?
In Pharo4⦠Marcus
Am 18.04.2014 um 11:45 schrieb Marcus Denker <marcus.denker@inria.fr>:
On 17 Apr 2014, at 21:13, Luc Fabresse <luc.fabresse@gmail.com> wrote:
hi all,
In a fresh image #30826, I tried:
Smalltalk image condenseChanges -> ZnInvalidUTF8 error
https://pharo.fogbugz.com/default.asp?12729& describes that but it is closed.
I tried the new version:
PharoChangesCondenser condense. -> parse error
Works fine for me. No error.
I investigated that yesterday while playing with shrinking of an image and Iâve found the culprit. https://pharo.fogbugz.com/default.asp?13207 Norbert
Do we open a new bug?
Is there another way that I missed?
Do you agree that we should remove condenseChanges from SmalltalkImage?
In Pharo4â¦
Marcus
Am 18.04.2014 um 12:20 schrieb Norbert Hartl <norbert@hartl.name>:
Am 18.04.2014 um 11:45 schrieb Marcus Denker <marcus.denker@inria.fr>:
On 17 Apr 2014, at 21:13, Luc Fabresse <luc.fabresse@gmail.com> wrote:
hi all,
In a fresh image #30826, I tried:
Smalltalk image condenseChanges -> ZnInvalidUTF8 error
https://pharo.fogbugz.com/default.asp?12729& describes that but it is closed.
I tried the new version:
PharoChangesCondenser condense. -> parse error
Works fine for me. No error.
Well, I did Smalltalk condenseChanges Norbert
I investigated that yesterday while playing with shrinking of an image and Iâve found the culprit.
https://pharo.fogbugz.com/default.asp?13207
Norbert
Do we open a new bug?
Is there another way that I missed?
Do you agree that we should remove condenseChanges from SmalltalkImage?
In Pharo4â¦
Marcus
On 18 Apr 2014, at 12:23, Norbert Hartl <norbert@hartl.name> wrote:
Smalltalk condenseChanges
That is old, please read https://pharo.fogbugz.com/f/cases/12729/Smalltalk-condenseChanges-raises-ZnI...
Am 18.04.2014 um 13:19 schrieb Sven Van Caekenberghe <sven@stfx.eu>:
On 18 Apr 2014, at 12:23, Norbert Hartl <norbert@hartl.name> wrote:
Smalltalk condenseChanges
That is old, please read https://pharo.fogbugz.com/f/cases/12729/Smalltalk-condenseChanges-raises-ZnI...
Ok, thanks, the search didnât bring up that issue. But if the PharoChangesCondenser is integrated in the image why is it not used when Smalltalk condenseChanges is invoked? Another case of âlet us load that stuff but donât make it publicâ? Norbert
On 18 Apr 2014, at 13:28, Norbert Hartl <norbert@hartl.name> wrote:
Am 18.04.2014 um 13:19 schrieb Sven Van Caekenberghe <sven@stfx.eu>:
On 18 Apr 2014, at 12:23, Norbert Hartl <norbert@hartl.name> wrote:
Smalltalk condenseChanges
That is old, please read https://pharo.fogbugz.com/f/cases/12729/Smalltalk-condenseChanges-raises-ZnI...
Ok, thanks, the search didnât bring up that issue. But if the PharoChangesCondenser is integrated in the image why is it not used when Smalltalk condenseChanges is invoked? Another case of âlet us load that stuff but donât make it publicâ?
Because it does not (yet) work on Windows. The new code is way better (faster, easier to understand).
participants (4)
-
Luc Fabresse -
Marcus Denker -
Norbert Hartl -
Sven Van Caekenberghe