On Tue, Dec 9, 2014 at 12:36 PM, Chris Muller <asqueaker@gmail.com> wrote:

On Tue, Dec 9, 2014 at 8:02 AM, Craig Latta <craig@netjam.org> wrote:

...

...

Do your pool references end up being valid?

Aha, the answer is no. So, I had to put some things in a separate package which must be loaded first. Among those things is a change required by a remote-object-aware version of IdentityDictionary>>scanFor:; the system was crashing when they were loaded in the wrong order.

Interesting. What did you have to do to #scanFor:, some kind of proxy detection or something?

PS -- I agree with Eliot that MC _should_ handle compiling subclasses of SharedPool first. I thought it did..

No, right now only methodAdditions are handled first. Look at MCPackageLoader>>basicLoad which is aching to be refactored to pull the exception handlers out. It should look like basicLoad "Load the contents of some package. This is the core loading method in Monticello. Be wary about modifying it unless you understand the details and dependencies of the various entities being modified." RecentMessages default suspendWhile: [[CurrentReadOnlySourceFiles cacheDuring: [[self innerBasicLoad] on: InMidstOfFileinNotification do: [:n | n resume: true]]] ensure: [self flushChangesFile]] innerBasicLoad "Load the contents of some package. This is the core loading method in Monticello. Be wary about modifying it unless you understand the details and dependencies of the various entities being modified." | pkgName | errorDefinitions := OrderedCollection new. "Obviously this isn't the package name but we don't have anything else to use here. ChangeSet current name will generally work since a CS is usually installed prior to installation." pkgName := ChangeSet current name. preamble ifNotNil: [ChangeSet current preambleString: (self preambleAsCommentNamed: pkgName)]. "Pass 1: Load everything but the methods, which are collected in methodAdditions." additions do: [:ea | ea isMethodDefinition ifTrue: [methodAdditions add: ea asMethodAddition] ifFalse: [[ea load] on: Error do: [errorDefinitions add: ea]]] displayingProgress: 'Reshaping ', pkgName. "Try again any delayed definitions" self shouldWarnAboutErrors ifTrue: [self warnAboutErrors]. errorDefinitions do: [:ea | ea load] displayingProgress: 'Reloading ', pkgName. "Pass 2: We compile new / changed methods" methodAdditions do: [:ea| ea createCompiledMethod] displayingProgress: 'Compiling ', pkgName. 'Installing ', pkgName displayProgressFrom: 0 to: 2 during: [:bar| "There is no progress *during* installation since a progress bar update will redraw the world and potentially call methods that we're just trying to install." bar value: 1. "Pass 3: Install the new / changed methods (this is a separate pass to allow compiler changes to be loaded)" methodAdditions do: [:ea| ea installMethod]. "Pass 4: Remove the obsolete methods" removals do: [:ea| ea unload]]. "Finally, notify observers for the method additions" methodAdditions do: [:each | each notifyObservers] "the message is fake but actually telling people how much time we spend in the notifications is embarrassing so lie instead" displayingProgress: 'Installing ', pkgName. additions do: [:ea | ea postloadOver: (self obsoletionFor: ea)] displayingProgress: 'Initializing ', pkgName But I have to say that I don't understand how basicLoad/innerBasicLoad sorts things. Confusing. Anyway, looks like the "Pass 1: Load everything but the methods, which are collected in methodAdditions." pass needs to be split into something that loads things that inherit from SharedPool first. -- best, Eliot