30296 ----- 10448 Smalltalk os should use instance of OSPlatform https://pharo.fogbugz.com/f/cases/10448 11225 fix DebuggerTest>>testBasic for the new debugger https://pharo.fogbugz.com/f/cases/11225 11218 SettingDeclaration>>exportAction not send and returns self https://pharo.fogbugz.com/f/cases/11218 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/ToolsTest-MarcusDenker.denker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1194.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tests-MarcusDenker.597.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.88... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Platforms-MarcusDenker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Localization-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Hashing-MarcusDenker.25... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Clipboard-MarcusDenker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/StartupPreferences-MarcusDenke... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Ring-Tests-Kernel-MarcusDenker... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Network-Kernel-MarcusDenker.89... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Multilingual-Languages-MarcusD... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Morphic-Base-MarcusDenker.52.d... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keys-MarcusDenker.10.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-KeyCombinations-Mar... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Core-MarcusDenker.1... http://smalltalkhub.com/mc/Pharo/Pharo30/main/KernelTests-MarcusDenker.537.d... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1532.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/FreeType-MarcusDenker.621.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Files-MarcusDenker.ducasse.300... http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Disk-MarcusDenker.6... http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Core-MarcusDenker.1... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Compatibility-MarcusDenker.18....
Hello, This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko Christophe. Le 24 juil. 2013 à 14:46, Marcus Denker a écrit :
30296 -----
10448 Smalltalk os should use instance of OSPlatform https://pharo.fogbugz.com/f/cases/10448
11225 fix DebuggerTest>>testBasic for the new debugger https://pharo.fogbugz.com/f/cases/11225
11218 SettingDeclaration>>exportAction not send and returns self https://pharo.fogbugz.com/f/cases/11218
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/ToolsTest-MarcusDenker.denker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1194.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tests-MarcusDenker.597.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.88... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Platforms-MarcusDenker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Localization-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Hashing-MarcusDenker.25... http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Clipboard-MarcusDenker.... http://smalltalkhub.com/mc/Pharo/Pharo30/main/StartupPreferences-MarcusDenke... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Ring-Tests-Kernel-MarcusDenker... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Network-Kernel-MarcusDenker.89... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Multilingual-Languages-MarcusD... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Morphic-Base-MarcusDenker.52.d... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keys-MarcusDenker.10.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-KeyCombinations-Mar... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Core-MarcusDenker.1... http://smalltalkhub.com/mc/Pharo/Pharo30/main/KernelTests-MarcusDenker.537.d... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1532.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/FreeType-MarcusDenker.621.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Files-MarcusDenker.ducasse.300... http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Disk-MarcusDenker.6... http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Core-MarcusDenker.1... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Compatibility-MarcusDenker.18....
On Jul 25, 2013, at 11:31 PM, Christophe Demarey <Christophe.Demarey@inria.fr> wrote:
Hello,
This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko
Yes, I saw that, too. It seems to be side effect of integrating 10448 Smalltalk os should use instance of OSPlatform But the question is why? Marcus
On 2013-07-26, at 08:37, Marcus Denker <marcus.denker@inria.fr> wrote:
On Jul 25, 2013, at 11:31 PM, Christophe Demarey <Christophe.Demarey@inria.fr> wrote:
Hello,
This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko
Yes, I saw that, too. It seems to be side effect of integrating
10448 Smalltalk os should use instance of OSPlatform
But the question is why?
Marcus
I remember seing some old keybinding code, but only for windows. Might be that I accidentally refactored something wrong in one of the platform checks. Does it still work under win/linux?
2013/7/26 Camillo Bruni <camillobruni@gmail.com>
On 2013-07-26, at 08:37, Marcus Denker <marcus.denker@inria.fr> wrote:
On Jul 25, 2013, at 11:31 PM, Christophe Demarey <
Christophe.Demarey@inria.fr> wrote:
Hello,
This release breaks the right click on the mouse. The event is not
handled anymore.
I checked #30295 => ok, images >= #30296 ko
Yes, I saw that, too. It seems to be side effect of integrating
10448 Smalltalk os should use instance of OSPlatform
But the question is why?
Marcus
I remember seing some old keybinding code, but only for windows. Might be that I accidentally refactored something wrong in one of the platform checks.
Does it still work under win/linux?
No, win and linux -- Best regards, Douaille Erwan <douaille.erwan@gmail.com>
On Jul 26, 2013, at 8:37 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Jul 25, 2013, at 11:31 PM, Christophe Demarey <Christophe.Demarey@inria.fr> wrote:
Hello,
This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko
Yes, I saw that, too. It seems to be side effect of integrating
10448 Smalltalk os should use instance of OSPlatform
But the question is why?
We found it! swapMouseButtons should be: swapMouseButtons ^ Smalltalk os isWindows not We will integrate it now Marcus
Thanks a lot Marcus and Clément. Le 26 juil. 2013 à 11:30, Marcus Denker a écrit :
On Jul 26, 2013, at 8:37 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Jul 25, 2013, at 11:31 PM, Christophe Demarey <Christophe.Demarey@inria.fr> wrote:
Hello,
This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko
Yes, I saw that, too. It seems to be side effect of integrating
10448 Smalltalk os should use instance of OSPlatform
But the question is why?
We found it! swapMouseButtons should be:
swapMouseButtons ^ Smalltalk os isWindows not
We will integrate it now
Marcus
participants (4)
-
Camillo Bruni -
Christophe Demarey -
Erwan Douaille -
Marcus Denker