Hello, I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue https://pharo.fogbugz.com/f/cases/17848 because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works. I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not? Thank you, Evan
Hi, -- Juraj Kubelka
El 30-04-2017, a las 15:25, Evan Donahue <emdonahu@gmail.com> escribió:
Hello,
I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue
https://pharo.fogbugz.com/f/cases/17848
because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.
I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not?
I am not in front of my computer, but you can open the repository and search for the SLICE. Than you should set resolve in FogBugz. Juraj
Thank you, Evan
if you open Pharo60Inbox you should be able to see it. On Sun, Apr 30, 2017 at 8:25 PM, Evan Donahue <emdonahu@gmail.com> wrote:
Hello,
I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue
https://pharo.fogbugz.com/f/cases/17848
because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.
I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not?
Thank you, Evan
On Mon, May 1, 2017 at 2:25 AM, Evan Donahue <emdonahu@gmail.com> wrote:
Hello,
I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue
https://pharo.fogbugz.com/f/cases/17848
because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.
I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save,
I presume you mean, after you typed your commit message, you hit <Accept>.
I did not see any confirmation. How can I tell if my slice was submitted or not?
It seems like it did not save. I opened Pharo60Inbox and filtering on 17848 shows nothing. You should have got up a window titled something like "Version: SLICE-Issue-NNNN-Blah-blah-blah-BenComan.1 Can you see it in your package cache? If its there, you can select it and choose <Copy> to copy it to Pharo60Inbox (but <Copy> requires you to have added your password to the Pharo60Inbox repo defintion). cheers -ben
Thanks. I have resubmitted and it seems to have worked. If anyone wants to let me know if it looks like I did everything right, I can hopefully move on to tackling other things. Thanks, Evan -- View this message in context: http://forum.world.st/First-commit-tp4944984p4945091.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Tx evan! We will have a look and this is great to have a new contributor!!! Stef On Tue, May 2, 2017 at 3:23 AM, Evan Donahue <emdonahu@gmail.com> wrote:
Thanks. I have resubmitted and it seems to have worked. If anyone wants to let me know if it looks like I did everything right, I can hopefully move on to tackling other things.
Thanks, Evan
-- View this message in context: http://forum.world.st/First- commit-tp4944984p4945091.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Ben Coman -
Evan Donahue -
Juraj Kubelka -
Stephane Ducasse