[Pharo-project] default styler is shout
Hi, In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do" Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ] Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do" self styler: (NullTextStyler new view: self; yourself). What do you say? Cheers, Doru -- www.tudorgirba.com "We are all great at making mistakes."
Why not delegate it in the used Editor ? SmalltalkEditor should use shout while the other editors should use the NullTextStyler. Maybe something like this: PluggableTextMorph>>useDefaultStyler self styler: textMorph editor styler Or better: PluggableTextMorph>>useDefaultStyler self styler: textMorph styler And then Editor>>styler On Sat, Jan 22, 2011 at 12:25 PM, Tudor Girba <tudor.girba@gmail.com> wrote:
Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ]
Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original:
useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
self styler: (NullTextStyler new view: self; yourself).
What do you say?
Cheers, Doru
-- www.tudorgirba.com
"We are all great at making mistakes."
Ufa,... Editor>>styler ^NullTextStyler new SmalltalkEditor>>styler ^... Guille On Sat, Jan 22, 2011 at 10:54 PM, Guillermo Polito < guillermopolito@gmail.com> wrote:
Why not delegate it in the used Editor ? SmalltalkEditor should use shout while the other editors should use the NullTextStyler. Maybe something like this:
PluggableTextMorph>>useDefaultStyler self styler: textMorph editor styler
Or better:
PluggableTextMorph>>useDefaultStyler self styler: textMorph styler
And then
Editor>>styler
On Sat, Jan 22, 2011 at 12:25 PM, Tudor Girba <tudor.girba@gmail.com>wrote:
Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ]
Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original:
useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
self styler: (NullTextStyler new view: self; yourself).
What do you say?
Cheers, Doru
-- www.tudorgirba.com
"We are all great at making mistakes."
Anyways, I'm looking that PluggableTextMorph>>textMorphClass "Answer the class used to create the receiver's textMorph" ^TextMorphForEditView and TextMorphForEditView>>editorClass ^ SmalltalkEditor So it's what I suggested needs a lot of work more... On Sat, Jan 22, 2011 at 10:58 PM, Guillermo Polito < guillermopolito@gmail.com> wrote:
Ufa,...
Editor>>styler ^NullTextStyler new
SmalltalkEditor>>styler ^...
Guille
On Sat, Jan 22, 2011 at 10:54 PM, Guillermo Polito < guillermopolito@gmail.com> wrote:
Why not delegate it in the used Editor ? SmalltalkEditor should use shout while the other editors should use the NullTextStyler. Maybe something like this:
PluggableTextMorph>>useDefaultStyler self styler: textMorph editor styler
Or better:
PluggableTextMorph>>useDefaultStyler self styler: textMorph styler
And then
Editor>>styler
On Sat, Jan 22, 2011 at 12:25 PM, Tudor Girba <tudor.girba@gmail.com>wrote:
Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ]
Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original:
useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
self styler: (NullTextStyler new view: self; yourself).
What do you say?
Cheers, Doru
-- www.tudorgirba.com
"We are all great at making mistakes."
This seems ok for me. When others reply open a ticket + changes and we will integrate that. On Jan 22, 2011, at 4:25 PM, Tudor Girba wrote:
Hi,
In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ]
Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original:
useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do"
self styler: (NullTextStyler new view: self; yourself).
What do you say?
Cheers, Doru
-- www.tudorgirba.com
"We are all great at making mistakes."
participants (3)
-
Guillermo Polito -
Stéphane Ducasse -
Tudor Girba