Re: [Pharo-project] Issue 2360 in pharo: [Failing Test] nil out locals in a block if readBeforeWritten
Updates: Summary: [Failing Test] nil out locals in a block if readBeforeWritten Comment #12 on issue 2360 by marcus.d...@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 (No comment was entered for this change.)
Comment #13 on issue 2360 by nicolas....@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 Name: SLICE-Issue-2360-SqueakCompilerEnh-Prerequisite-nice.1 Dependencies: Compiler-nice.275 First stage for reducing Squeak/Pharo Compiler differences: This is a pre-requisite for issue 2360 - let visitor pattern #accept: return its own result rather than the node - remove old code generation methods - merge ByteCodeAgnosticMethodNode into MethodNode MessageNode initialize must be performed at the end of this stage.
Updates: Status: FixProposed Comment #14 on issue 2360 by nicolas....@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 Name: SLICE-Issue-2360-SqueakCompilerEnh-Part2-nice.1 Dependencies: CompilerTests-nice.78, Compiler-nice.276 Part2: - correctly move 'locationCounter localsPool' in MethodNode ivar (they were undeclared) - use #notOptimizedIn: rather #than noteOptimized. - do not optimize a todo that would overwrite its limit (common changes with 3677) - connect the OptimizedBlockLocalTempReadBeforeWrittenVisitor to nilReadBeforeWrittenTemps in optimized blocks - add #testOptimizedBlockLocalNilling1 and #testOptimizedBlockLocalNilling2
Comment #15 on issue 2360 by nicolas....@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 Name: SLICE-Issue-2360-SqueakCompilerEnh-Part3-OptimizedRepeatLoop-nice.1 Dependencies: Compiler-nice.277 This change includes Compiler and Decompiler changes to handle optimized #repeat loops. Note that MessageNode class>>#initialize of Part2 already includes necessary hook. (Sorry, some methods have changed several times in trunk, and it's easier to upgrade several fixes at once). If you don't want this change in Pharo (why ?) then don't forget to change MessageNode class>>#initialize
Comment #16 on issue 2360 by marcus.d...@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 Prerequisite is in 13127
Updates: Status: Closed Comment #17 on issue 2360 by marcus.d...@gmail.com: [Failing Test] nil out locals in a block if readBeforeWritten http://code.google.com/p/pharo/issues/detail?id=2360 all now in 13129
participants (1)
-
pharo＠googlecode.com