SpecTableLayout not in Pahro 4
I made several commits to Spec (https://github.com/spec-framework/spec/pull/15) shortly before the license change. I thought these changes would be merged into Pharo. However, they are not in Pahro 4 as for now. Are there any problems? -- View this message in context: http://forum.world.st/SpecTableLayout-not-in-Pahro-4-tp4812428.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Tue, Mar 17, 2015 at 5:50 AM, webwarrior <reg@webwarrior.ws> wrote:
I made several commits to Spec (https://github.com/spec-framework/spec/pull/15) shortly before the license change.
That is the problem. After the license change Pharo could not pull from that repository.
I thought these changes would be merged into Pharo. However, they are not in Pharo 4 as for now.
We could not. The license was incompatible.
Are there any problems?
You remain the copyright holder of your code, so you are free to submit your change directly to Pharo - but it is too late now for Pharo 4. Such is the knock on effect of someone unilaterally changing other peoples MIT contributions to GPL. However I am not sure if Spec is maintained in-Image are in a different external repository. cheers -ben
Hi, since the PR merge was just around the license change nobody probably noticed it. Now you are both copyright holder, and the Spec license is back to MIT so it could be integrated, however: * Pharo 4.0 is due freeze in two weeks, so no new features should be added * There are currently larger Spec changes underway, so it may not be compatible and fixes may be required So please create an issue here https://pharo.fogbugz.com/ for it is not forgotten.
However I am not sure if Spec is maintained in-Image are in a different external repository. in image
Peter
Created issue in fogbugz. Also, if I decide to distribute a library that requires SpecTableLayout, how to do it properly? Basically most of changes are new classes (so may be shipped in any package), but there is also a modification to existing method in SpecInterpreter. -- View this message in context: http://forum.world.st/SpecTableLayout-not-in-Pahro-4-tp4812428p4812633.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
I am assuming requiring SpecTableLayout after it is incorporated into Spec? There is currently no configuration for spec since it is inside the image, so the only way would be to specify version of Pharo (i.e. it's incorporated in version X, so the user needs at least Pharo X) or testing whether the class already exists. As for overriding behavior - loading a package would rewrite existing code. There may be some issues if you were to concurrently update both Spec and your package, and then the latest would win; but there may be better solution. Peter On Tue, Mar 17, 2015 at 5:24 PM, webwarrior <reg@webwarrior.ws> wrote:
Created issue in fogbugz.
Also, if I decide to distribute a library that requires SpecTableLayout, how to do it properly? Basically most of changes are new classes (so may be shipped in any package), but there is also a modification to existing method in SpecInterpreter.
-- View this message in context: http://forum.world.st/SpecTableLayout-not-in-Pahro-4-tp4812428p4812633.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
We can add a configurationOfSpec but somebody should find the old and resurrect it. I remember that I started to remove bad dependencies Le 17/3/15 18:04, Peter Uhnák a écrit :
I am assuming requiring SpecTableLayout after it is incorporated into Spec? There is currently no configuration for spec since it is inside the image, so the only way would be to specify version of Pharo (i.e. it's incorporated in version X, so the user needs at least Pharo X) or testing whether the class already exists.
As for overriding behavior - loading a package would rewrite existing code.
There may be some issues if you were to concurrently update both Spec and your package, and then the latest would win; but there may be better solution.
Peter
On Tue, Mar 17, 2015 at 5:24 PM, webwarrior <reg@webwarrior.ws <mailto:reg@webwarrior.ws>> wrote:
Created issue in fogbugz.
Also, if I decide to distribute a library that requires SpecTableLayout, how to do it properly? Basically most of changes are new classes (so may be shipped in any package), but there is also a modification to existing method in SpecInterpreter.
-- View this message in context: http://forum.world.st/SpecTableLayout-not-in-Pahro-4-tp4812428p4812633.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Could you Create an issue on the Pharo bugtracker Publish your changes in a slice in the inbox of Pharo so that we check if we can integrate them or not in Pharo 40? I'm sorry about what happened around Spec. We did not want to have a look a the github com because we did not want to fuel the nastiness of Ben. We are still insulted on the web page but I asked the lawyers not to react and let the story die. Stef Le 16/3/15 22:50, webwarrior a écrit :
I made several commits to Spec (https://github.com/spec-framework/spec/pull/15) shortly before the license change. I thought these changes would be merged into Pharo. However, they are not in Pahro 4 as for now. Are there any problems?
-- View this message in context: http://forum.world.st/SpecTableLayout-not-in-Pahro-4-tp4812428.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Ben Coman -
Peter Uhnák -
stepharo -
webwarrior