[Pharo-project] how this test can be right
testAsCommaString {OrderedCollection new. Set new.} do: [ :coll | self assert: coll asCommaString = ''. coll add: 1. self assert: coll asCommaString = '1'. coll add: 2; add: 3. self assert: coll asCommaString = '1, 2, 3']. I was never said that elements are iterate in a set the same way that they are added. Stef
I was never said that elements are iterate in a set the same way that they are added.
That's just by chance that it works, because the hash of a SmallInteger is itself. As soon as the set starts to grow or as soon as you don't add the numbers in order the result will be different. I wouldn't write such a test, it depends on the internal implementation of Set and SmallInteger and is likely to break. Cheers, Lukas -- Lukas Renggli http://www.lukas-renggli.ch
Yeap. I will remove it. In the future I plant to certainly integrate the WADictionary with key order... I would like to have a really good collection library. But first the tests :) On Jan 16, 2009, at 9:22 AM, Lukas Renggli wrote:
I was never said that elements are iterate in a set the same way that they are added.
That's just by chance that it works, because the hash of a SmallInteger is itself. As soon as the set starts to grow or as soon as you don't add the numbers in order the result will be different. I wouldn't write such a test, it depends on the internal implementation of Set and SmallInteger and is likely to break.
Cheers, Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Lukas Renggli -
Stéphane Ducasse