Re: [Pharo-project] Issue 1915 in pharo: Making ToolSet more flexible
Comment #2 on issue 1915 by marianopeck: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 Here was the discussion http://forum.world.st/Questions-about-ToolSet-td1460544.html
Comment #3 on issue 1915 by renggli: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 The monolithic ToolSet is indeed a big problem. I do not understand the proposed solution. I suggest that each of Browser, Debugger, Inspector, Transcript, Workspace, Process get their own AppRegistry subclass. There are already various (mostly unused) AppRegistry subclasses, splitting ToolSet into multiple classes would solve most of the problem. An alternative (and probably even better) would be to make the standard tools unloadable, including their class extensions like Object>>#inspect, Object>>#browse, ... Like this the registry would not be necessary and people could just load whatever implementation they want (the menus are already configurable by other means). Lukas
Comment #4 on issue 1915 by siguctua: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 Please review the http://www.mail-archive.com/pharo-project@lists.gforge.inria.fr/msg02869.htm... i did this 2 years ago.
Updates: Labels: Milestone-1.3 Comment #5 on issue 1915 by marianopeck: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 (No comment was entered for this change.)
Comment #6 on issue 1915 by siguc...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 This is a changesets for new ToolRegistry. See class comment for use. A pomodoro technique should be applied to fix all direct references to various tools. A following script can be used to detect them: Smalltalk tools browseDirectToolReferences Attachments: ToolRegistry.3.cs 10.1 KB ToolRegistry-changes.8.cs 30.3 KB
Comment #7 on issue 1915 by siguc...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 We should state that the menu category is for backward compatibility and we should remove them afterwards.
Updates: Status: Fixed Comment #8 on issue 1915 by siguc...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 browseDirectToolReferences "Browse all direct references of all of my registered tools. Useful for converting calls like: MyTool foo into: Smalltalk tools myTool foo " | bindings sn | bindings := tools values select: [:each | each value isBehavior ] thenCollect: [:each | each value binding ]. bindings := bindings copyWith: (Smalltalk bindingOf: #ToolSet). sn := SystemNavigation default. ^ sn browseMessageList: ( sn allMethodsSelect: [:m | (m literals allButLast select: [:lit| lit isVariableBinding ]) includesAnyOf: bindings ] ) name: 'All direct references to tools to fix'
Comment #9 on issue 1915 by siguc...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 (No comment was entered for this change.) Attachments: FixingToolsReferences.1.cs 24.5 KB
Updates: Status: FixProposed Comment #10 on issue 1915 by marcus.d...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 (No comment was entered for this change.)
Comment #11 on issue 1915 by marcus.d...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 Issue 3788 has been merged into this issue.
Comment #12 on issue 1915 by siguc...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 the above changesets are in 13156. more to come
Updates: Status: Started Comment #13 on issue 1915 by marcus.d...@gmail.com: Making ToolSet more flexible http://code.google.com/p/pharo/issues/detail?id=1915 (No comment was entered for this change.)
participants (1)
-
pharo＠googlecode.com