[Pharo-project] Closure fixes have reverted changes in the kernel (again)
I started looking at the failing tests and noted that a change (refactoring of how Traits access the changes/sources) in CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but I wonder which other closure fixes have reverted previous changes that we applied to Pharo-core. What is the easiest way to review the changes of the recent closure fixes introduced to Pharo-core? Since Eliot works against Squeak, I presume, any of his changes may be problematic and has to be reviewed. Cheers, Adrian ___________________ http://www.adrian-lienhard.ch/
I started looking at the failing tests and noted that a change (refactoring of how Traits access the changes/sources) in CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but I wonder which other closure fixes have reverted previous changes that we applied to Pharo-core. What is the easiest way to review the changes of the recent closure fixes introduced to Pharo-core? Since Eliot works against Squeak, I presume, any of his changes may be problematic and has to be reviewed.
The best things would be to take the image just before the fixes and merge the package we pushed in. indeed this is important to do that. Stef
participants (2)
-
Adrian Lienhard -
Stéphane Ducasse