[Review needed] fix for Pharo2 "text highlighting incorrect"
12241 text highlighting incorrect https://pharo.fogbugz.com/f/cases/12241 What needs to be done? -> does it fix the bug? -> Is the fix plausibly ok? -> Is this a problem in Pharo3, too? If yes â> add issue for back porting, -> make slice for 3
That's me the solution provided doesn't work very well either. I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that code with something that clearly knows how to bounds a subset of the text). I'll postpone it for now. If 3.0 gets a new text editor, then that code will be different. Thierry Le 27/11/2013 09:58, Marcus Denker a écrit :
12241 text highlighting incorrect https://pharo.fogbugz.com/f/cases/12241
What needs to be done?
-> does it fix the bug? -> Is the fix plausibly ok? -> Is this a problem in Pharo3, too? If yes â> add issue for back porting, -> make slice for 3
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
That's me
the solution provided doesn't work very well either.
I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that code with something that clearly knows how to bounds a subset of the text).
I'll postpone it for now. If 3.0 gets a new text editor, then that code will be different.
It will not. Igor got stuck and he is sick and depressed right now. Stef
Le 27/11/2013 20:36, Stéphane Ducasse a écrit :
That's me
the solution provided doesn't work very well either.
I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that code with something that clearly knows how to bounds a subset of the text).
I'll postpone it for now. If 3.0 gets a new text editor, then that code will be different.
It will not. Igor got stuck and he is sick and depressed right now.
That's sad; I was seriously interested in seeing what Igor has managed to do. I'll spend some time on this issue and set the issues right for 2.0 and 3.0; many good things can be done with that highlighting working. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Are you talking about text highlighting in the debugger or is this not related ? 2013/11/28 Goubier Thierry <thierry.goubier@cea.fr>
Le 27/11/2013 20:36, Stéphane Ducasse a écrit :
That's me
the solution provided doesn't work very well either.
I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that code with something that clearly knows how to bounds a subset of the text).
I'll postpone it for now. If 3.0 gets a new text editor, then that code will be different.
It will not. Igor got stuck and he is sick and depressed right now.
That's sad; I was seriously interested in seeing what Igor has managed to do.
I'll spend some time on this issue and set the issues right for 2.0 and 3.0; many good things can be done with that highlighting working.
Thierry
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
That's sad; I was seriously interested in seeing what Igor has managed to do.
Normally there is an up to dat configuration in the Athens and TextModel repository. Now he is back working on it. But please have a look we need clients pushing igor. Igor is overwhelmed by questions :) But the more people will come the more they will ask questions and the more we will answer (or prepare docs to avoid to have to repeat all the time). Stef
I'll spend some time on this issue and set the issues right for 2.0 and 3.0; many good things can be done with that highlighting working.
Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
participants (4)
-
Clément Bera -
Goubier Thierry -
Marcus Denker -
Stéphane Ducasse