Problems with the removal of Nautilus
Hi, I've just tried to create a new package in Calypso and I got bitten by this: https://pharo.fogbugz.com/f/cases/21804/Creating-a-Package-from-Calypso-prod... Creating a new package was an extension of Nautilus, and was never introduced in RPackage. How should we procceed? How can we know all the "extensions" that were not so? -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
Can someone check this https://github.com/pharo-project/pharo/pull/1293 ? On Fri, May 4, 2018 at 10:19 AM, Guillermo Polito <guillermopolito@gmail.com
wrote:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a- Package-from-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
-- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
2018-05-04 10:19 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a- Package-from-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
I will try to check them -- Pavel
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
In an old image with Nautilus I did this: names := #('Nautilus' 'NautilusCommon' 'Nautilus-GroupManager' 'Nautilus-GroupManagerUI' 'QualityAssistant' 'QualityAssistantRecording' 'QualityAssistant-Test'). selectors := names flatCollect: [ :packageName | packageName asPackage extensionMethods collect: #selector as: Set ]. selectors reject: [ :each | senders := SystemNavigation default allSendersOf: each. senders allSatisfy: [ :sender | names includes: sender package name ] ]. This is the result of problematic extensions. Some of them are solved by the removal, most of them are menu entries in NautilusRefactorings. The mentioned selector #createPackageNamed: is there. "#(#codeRewritingClass: #methodRefactoring: #refactoringMenu: #varRefactoringSubMenu: #groupRefactoring: #createPackageNamed: #sourceCodeRefactoring: #refactoringSubmenu: #instVarRefactoring: #refactoringMethod: #browse #sourceCodeRefactoringMenu: #asRingDefinition #addCategory:before: #hasErrorTest #inheritsFrom: #compile:classified:notifying: #traits #hasPassedTest #extendingPackages #browsedEnvironment: #hasFailedTest #notifyViewedDiffFor:of: #repairIcon #color #annotateRubricText: #notifyBanInitiatedFor:of: #notifyCritique:AutoFixedFor:)" I will check them and make the issue entries. -- Pavel 2018-05-04 13:08 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
2018-05-04 10:19 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a-Package- from-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
I will try to check them
-- Pavel
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
createPackageNamed: - solved by you browse - adds an ability for RBBrowserEnvironment to be browsed by Nautilus, no action needed asRingDefinition - for UndefinedObject, solved by Nautilus removal, no action needed addCategory:before: - solved by Nautilus removal, no action needed hasErrorTest - solved by Nautilus removal, no action needed inheritsFrom: - solved by Nautilus removal, no action needed compile:classified:notifying: - solved by Nautilus removal, no action needed traits - solved by Nautilus removal, no action needed hasPassedTest - solved by Nautilus removal, no action needed extendingPackages - solved by Nautilus removal, no action needed hasFailedTest - solved by Nautilus removal, no action needed #color - solved by Nautilus removal, no action needed annotateRubricText: - solved by Nautilus removal, no action needed The rest are the menu entries ( https://pharo.fogbugz.com/f/cases/21827/clean-NautilusRefactoring-menu-entri... ). So at least from the method extensions point of view, we should be safe. Thanks -- Pavel 2018-05-04 13:30 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
In an old image with Nautilus I did this:
names := #('Nautilus' 'NautilusCommon' 'Nautilus-GroupManager' 'Nautilus-GroupManagerUI' 'QualityAssistant' 'QualityAssistantRecording' 'QualityAssistant-Test').
selectors := names flatCollect: [ :packageName | packageName asPackage extensionMethods collect: #selector as: Set ]. selectors reject: [ :each | senders := SystemNavigation default allSendersOf: each. senders allSatisfy: [ :sender | names includes: sender package name ] ].
This is the result of problematic extensions. Some of them are solved by the removal, most of them are menu entries in NautilusRefactorings. The mentioned selector #createPackageNamed: is there.
"#(#codeRewritingClass: #methodRefactoring: #refactoringMenu: #varRefactoringSubMenu: #groupRefactoring: #createPackageNamed: #sourceCodeRefactoring: #refactoringSubmenu: #instVarRefactoring: #refactoringMethod: #browse #sourceCodeRefactoringMenu: #asRingDefinition #addCategory:before: #hasErrorTest #inheritsFrom: #compile:classified:notifying: #traits #hasPassedTest #extendingPackages #browsedEnvironment: #hasFailedTest #notifyViewedDiffFor:of: #repairIcon #color #annotateRubricText: #notifyBanInitiatedFor:of: #notifyCritique:AutoFixedFor:)"
I will check them and make the issue entries.
-- Pavel
2018-05-04 13:08 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
2018-05-04 10:19 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a-Package-f rom-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
I will try to check them
-- Pavel
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
Thanks Pavel 2018-05-04 16:24 GMT+03:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
createPackageNamed: - solved by you browse - adds an ability for RBBrowserEnvironment to be browsed by Nautilus, no action needed asRingDefinition - for UndefinedObject, solved by Nautilus removal, no action needed addCategory:before: - solved by Nautilus removal, no action needed hasErrorTest - solved by Nautilus removal, no action needed inheritsFrom: - solved by Nautilus removal, no action needed compile:classified:notifying: - solved by Nautilus removal, no action needed traits - solved by Nautilus removal, no action needed hasPassedTest - solved by Nautilus removal, no action needed extendingPackages - solved by Nautilus removal, no action needed hasFailedTest - solved by Nautilus removal, no action needed #color - solved by Nautilus removal, no action needed annotateRubricText: - solved by Nautilus removal, no action needed
The rest are the menu entries (https://pharo.fogbugz.com/f/ cases/21827/clean-NautilusRefactoring-menu-entries-for-Nautilus).
So at least from the method extensions point of view, we should be safe. Thanks
-- Pavel
2018-05-04 13:30 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
In an old image with Nautilus I did this:
names := #('Nautilus' 'NautilusCommon' 'Nautilus-GroupManager' 'Nautilus-GroupManagerUI' 'QualityAssistant' 'QualityAssistantRecording' 'QualityAssistant-Test').
selectors := names flatCollect: [ :packageName | packageName asPackage extensionMethods collect: #selector as: Set ]. selectors reject: [ :each | senders := SystemNavigation default allSendersOf: each. senders allSatisfy: [ :sender | names includes: sender package name ] ].
This is the result of problematic extensions. Some of them are solved by the removal, most of them are menu entries in NautilusRefactorings. The mentioned selector #createPackageNamed: is there.
"#(#codeRewritingClass: #methodRefactoring: #refactoringMenu: #varRefactoringSubMenu: #groupRefactoring: #createPackageNamed: #sourceCodeRefactoring: #refactoringSubmenu: #instVarRefactoring: #refactoringMethod: #browse #sourceCodeRefactoringMenu: #asRingDefinition #addCategory:before: #hasErrorTest #inheritsFrom: #compile:classified:notifying: #traits #hasPassedTest #extendingPackages #browsedEnvironment: #hasFailedTest #notifyViewedDiffFor:of: #repairIcon #color #annotateRubricText: #notifyBanInitiatedFor:of: #notifyCritique:AutoFixedFor:)"
I will check them and make the issue entries.
-- Pavel
2018-05-04 13:08 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
2018-05-04 10:19 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a-Package-f rom-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
I will try to check them
-- Pavel
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
Cool, Thanks! On Fri, May 4, 2018 at 3:24 PM, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
createPackageNamed: - solved by you browse - adds an ability for RBBrowserEnvironment to be browsed by Nautilus, no action needed asRingDefinition - for UndefinedObject, solved by Nautilus removal, no action needed addCategory:before: - solved by Nautilus removal, no action needed hasErrorTest - solved by Nautilus removal, no action needed inheritsFrom: - solved by Nautilus removal, no action needed compile:classified:notifying: - solved by Nautilus removal, no action needed traits - solved by Nautilus removal, no action needed hasPassedTest - solved by Nautilus removal, no action needed extendingPackages - solved by Nautilus removal, no action needed hasFailedTest - solved by Nautilus removal, no action needed #color - solved by Nautilus removal, no action needed annotateRubricText: - solved by Nautilus removal, no action needed
The rest are the menu entries (https://pharo.fogbugz.com/f/ cases/21827/clean-NautilusRefactoring-menu-entries-for-Nautilus).
So at least from the method extensions point of view, we should be safe. Thanks
-- Pavel
2018-05-04 13:30 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
In an old image with Nautilus I did this:
names := #('Nautilus' 'NautilusCommon' 'Nautilus-GroupManager' 'Nautilus-GroupManagerUI' 'QualityAssistant' 'QualityAssistantRecording' 'QualityAssistant-Test').
selectors := names flatCollect: [ :packageName | packageName asPackage extensionMethods collect: #selector as: Set ]. selectors reject: [ :each | senders := SystemNavigation default allSendersOf: each. senders allSatisfy: [ :sender | names includes: sender package name ] ].
This is the result of problematic extensions. Some of them are solved by the removal, most of them are menu entries in NautilusRefactorings. The mentioned selector #createPackageNamed: is there.
"#(#codeRewritingClass: #methodRefactoring: #refactoringMenu: #varRefactoringSubMenu: #groupRefactoring: #createPackageNamed: #sourceCodeRefactoring: #refactoringSubmenu: #instVarRefactoring: #refactoringMethod: #browse #sourceCodeRefactoringMenu: #asRingDefinition #addCategory:before: #hasErrorTest #inheritsFrom: #compile:classified:notifying: #traits #hasPassedTest #extendingPackages #browsedEnvironment: #hasFailedTest #notifyViewedDiffFor:of: #repairIcon #color #annotateRubricText: #notifyBanInitiatedFor:of: #notifyCritique:AutoFixedFor:)"
I will check them and make the issue entries.
-- Pavel
2018-05-04 13:08 GMT+02:00 Pavel Krivanek <pavel.krivanek@gmail.com>:
2018-05-04 10:19 GMT+02:00 Guillermo Polito <guillermopolito@gmail.com>:
Hi,
I've just tried to create a new package in Calypso and I got bitten by this:
https://pharo.fogbugz.com/f/cases/21804/Creating-a-Package-f rom-Calypso-produces-DNU
Creating a new package was an extension of Nautilus, and was never introduced in RPackage.
How should we procceed? How can we know all the "extensions" that were not so?
I will try to check them
-- Pavel
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13
-- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
participants (3)
-
Denis Kudriashov -
Guillermo Polito -
Pavel Krivanek