[Pharo-project] OrderedIdentityDictionary in a more general package
The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core". Since it is useful also in other scenarios and I do not want a dependency on spec: wouldnt it make sense to move it to a more common "Collections-..." package. Since there is already "Collections-Unordered" I would suggest to put it into "Collections-Ordered". Mmmhh ... but then class OrderedCollection would have to move from "Collections-Sequenceable" to "Collections-Ordered" as well (at least from the name). Any comments on that... Thx T.
On 30 January 2013 19:44, Torsten Bergmann <astares@gmx.de> wrote:
The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core".
Since it is useful also in other scenarios and I do not want a dependency on spec: wouldnt it make sense to move it to a more common "Collections-..." package.
Since there is already "Collections-Unordered" I would suggest to put it into "Collections-Ordered". Mmmhh ... but then class OrderedCollection would have to move from "Collections-Sequenceable" to "Collections-Ordered" as well (at least from the name).
Any comments on that...
Thx T.
If something is ordered, surely it's sequenceable? Why not put it in Collections-Sequenceable? frank
On Jan 30, 2013, at 4:44 PM, Torsten Bergmann wrote:
The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core".
Since it is useful also in other scenarios and I do not want a dependency on spec: wouldnt it make sense to move it to a more common "Collections-..." package.
good idea. Do you know the test coverage of the class? Because it would be nice to run hapao on it and write some tests if there are none.
Since there is already "Collections-Unordered" I would suggest to put it into "Collections-Ordered". Mmmhh ... but then class OrderedCollection would have to move from "Collections-Sequenceable" to "Collections-Ordered" as well (at least from the name).
Any comments on that...
Thx T.
Actually this was in the bug tracker http://code.google.com/p/pharo/issues/detail?id=2759&can=1&q=orderedDictiona... error 2759 This OrderedIdentityDictionary is only used for user interface that is why it is on Spec-Core for now. See the bug report for more details. 2013/1/31 Stéphane Ducasse <stephane.ducasse@inria.fr>
On Jan 30, 2013, at 4:44 PM, Torsten Bergmann wrote:
The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core".
Since it is useful also in other scenarios and I do not want a dependency on spec: wouldnt it make sense to move it to a more common "Collections-..." package.
good idea. Do you know the test coverage of the class? Because it would be nice to run hapao on it and write some tests if there are none.
Since there is already "Collections-Unordered" I would suggest to put it into "Collections-Ordered". Mmmhh ... but then class OrderedCollection would have to move from
"Collections-Sequenceable"
to "Collections-Ordered" as well (at least from the name).
Any comments on that...
Thx T.
Ok so it would be good to address the issue. We should get better and larger collection choice. Since you already add a look could you check it again. Stef On Jan 31, 2013, at 5:49 AM, Clément Bera wrote:
Actually this was in the bug tracker
http://code.google.com/p/pharo/issues/detail?id=2759&can=1&q=orderedDictiona...
error 2759
This OrderedIdentityDictionary is only used for user interface that is why it is on Spec-Core for now. See the bug report for more details.
2013/1/31 Stéphane Ducasse <stephane.ducasse@inria.fr>
On Jan 30, 2013, at 4:44 PM, Torsten Bergmann wrote:
The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core".
Since it is useful also in other scenarios and I do not want a dependency on spec: wouldnt it make sense to move it to a more common "Collections-..." package.
good idea. Do you know the test coverage of the class? Because it would be nice to run hapao on it and write some tests if there are none.
Since there is already "Collections-Unordered" I would suggest to put it into "Collections-Ordered". Mmmhh ... but then class OrderedCollection would have to move from "Collections-Sequenceable" to "Collections-Ordered" as well (at least from the name).
Any comments on that...
Thx T.
participants (4)
-
Clément Bera -
Frank Shearar -
Stéphane Ducasse -
Torsten Bergmann