[Pharo-project] DateAndTime>>asUnixTime should ignore timezones?
I've filed a new issue: #2644<http://code.google.com/p/pharo/issues/detail?id=2644>
Thanks did you run the tests after your fixes? Because I tried to integrate another fixes related to date = string as proposed in Squeak by chris but a lot of date related tests break. and we should be cautious. Stef On Jul 5, 2010, at 7:31 PM, Nick Ager wrote:
I've filed a new issue: #2644 _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi Stef did you run the tests after your fixes?
Because I tried to integrate another fixes related to date = string as proposed in Squeak by chris but a lot of date related tests break. and we should be cautious.
I checked for senders of asUnixTime in the image and there weren't any. Just to be on the safe side I've run all the tests in KernelTests-Chronology; all green. I've updated the issue (#2644<http://code.google.com/p/pharo/issues/detail?id=2644>) to include a test and have attached a change set which includes the change to asUnixTime and an associated test.
thanks a lot. Stef On Jul 6, 2010, at 12:31 PM, Nick Ager wrote:
Hi Stef
did you run the tests after your fixes? Because I tried to integrate another fixes related to date = string as proposed in Squeak by chris but a lot of date related tests break. and we should be cautious.
I checked for senders of asUnixTime in the image and there weren't any. Just to be on the safe side I've run all the tests in KernelTests-Chronology; all green.
I've updated the issue (#2644) to include a test and have attached a change set which includes the change to asUnixTime and an associated test. _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Nick Ager -
Stéphane Ducasse